From: Michal Simek <monstr@monstr.eu>
To: Ryan Mallon <rmallon@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@secretlab.ca>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 4/4] microblaze: Remove NO_IRQ from architecture
Date: Thu, 22 Dec 2011 09:06:34 +0100 [thread overview]
Message-ID: <4EF2E50A.7040506@monstr.eu> (raw)
In-Reply-To: <4EF258FE.9030709@gmail.com>
Ryan Mallon wrote:
> On 22/12/11 01:32, Michal Simek wrote:
>
>> NO_IRQ shouldn't be used by any driver. All Microblaze
>> drivers are fixed that's why NO_IRQ can be removed.
>
>
> This only describes half of what the patch does. You should also state
> that arch/microblaze/pci/pci-common.c has references to NO_IRQ removed.
> Maybe it' worth splitting this patch in half so the final patch just
> does the removal of the NO_IRQ definition, but maybe that is overkill?
I have decided to remove NO_IRQ from arch/microblaze in one patch.
It is less painful because if there is any problem with PCI you can revert
just one patch instead of two.
Drivers out of arch/microblaze must be in separate patches.
> Other than that, for the whole series:
>
> Reviewed-by: Ryan Mallon <rmallon@gmail.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2011-12-22 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 14:32 [PATCH 1/4] block: xsysace: Don't use NO_IRQ Michal Simek
[not found] ` <1324477932-19262-1-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2011-12-21 14:32 ` [PATCH 2/4] net: ethernet: xilinx: Don't use NO_IRQ in xilinx Michal Simek
[not found] ` <1324477932-19262-2-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2011-12-21 14:32 ` [PATCH 3/4] input: xilinx_ps2: Don't use NO_IRQ Michal Simek
[not found] ` <1324477932-19262-3-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2011-12-21 14:32 ` [PATCH 4/4] microblaze: Remove NO_IRQ from architecture Michal Simek
2011-12-21 22:09 ` Ryan Mallon
2011-12-22 8:06 ` Michal Simek [this message]
[not found] ` <1324477932-19262-4-git-send-email-monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2012-01-02 8:22 ` Grant Likely
2012-01-02 8:21 ` [PATCH 3/4] input: xilinx_ps2: Don't use NO_IRQ Grant Likely
2012-01-02 8:21 ` [PATCH 2/4] net: ethernet: xilinx: Don't use NO_IRQ in xilinx Grant Likely
2011-12-21 20:43 ` David Miller
2011-12-29 9:27 ` [PATCH 1/4] block: xsysace: Don't use NO_IRQ Michal Simek
2012-01-02 8:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF2E50A.7040506@monstr.eu \
--to=monstr@monstr.eu \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).