* [PATCH] bonding: document undocumented active_slave sysfs entry.
@ 2011-12-26 12:19 Nicolas de Pesloüan
2011-12-26 20:20 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Nicolas de Pesloüan @ 2011-12-26 12:19 UTC (permalink / raw)
To: netdev; +Cc: Nicolas de Pesloüan, Jay Vosburgh, Andy Gospodarek
Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
cc: Jay Vosburgh <fubar@us.ibm.com>
cc: Andy Gospodarek <andy@greyhouse.net>
---
Documentation/networking/bonding.txt | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt
index 91df678..83b44c2 100644
--- a/Documentation/networking/bonding.txt
+++ b/Documentation/networking/bonding.txt
@@ -196,6 +196,20 @@ or, for backwards compatibility, the option value. E.g.,
The parameters are as follows:
+active_slave
+
+ Specifies the active slave for modes that support it (active-backup,
+ balance-alb and balance-tlb). The possible values are one of the
+ currently enslaved slaves. The selected slave must be up and the
+ underlying link must be up too.
+
+ Note that this is only available through the sysfs interface. No module
+ parameter by that name exists.
+
+ The default value is empty (no active slave). It will automatically be
+ set every time an active slave is selected by normal bonding operation.
+ The current active slave can be read from this sysfs entry.
+
ad_select
Specifies the 802.3ad aggregation selection logic to use. The
--
1.7.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] bonding: document undocumented active_slave sysfs entry.
2011-12-26 12:19 [PATCH] bonding: document undocumented active_slave sysfs entry Nicolas de Pesloüan
@ 2011-12-26 20:20 ` David Miller
2011-12-26 21:10 ` Jay Vosburgh
2011-12-26 23:35 ` [PATCH V2] " Nicolas de Pesloüan
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-12-26 20:20 UTC (permalink / raw)
To: nicolas.2p.debian; +Cc: netdev, fubar, andy
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Date: Mon, 26 Dec 2011 13:19:15 +0100
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
> cc: Jay Vosburgh <fubar@us.ibm.com>
> cc: Andy Gospodarek <andy@greyhouse.net>
Jay/Andy, please review.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bonding: document undocumented active_slave sysfs entry.
2011-12-26 12:19 [PATCH] bonding: document undocumented active_slave sysfs entry Nicolas de Pesloüan
2011-12-26 20:20 ` David Miller
@ 2011-12-26 21:10 ` Jay Vosburgh
2011-12-26 22:51 ` Nicolas de Pesloüan
2011-12-26 23:35 ` [PATCH V2] " Nicolas de Pesloüan
2 siblings, 1 reply; 6+ messages in thread
From: Jay Vosburgh @ 2011-12-26 21:10 UTC (permalink / raw)
To: Nicolas de Pesloüan; +Cc: netdev, Andy Gospodarek
Nicolas de Pesloüan <nicolas.2p.debian@free.fr> wrote:
>Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
>cc: Jay Vosburgh <fubar@us.ibm.com>
>cc: Andy Gospodarek <andy@greyhouse.net>
>
>---
> Documentation/networking/bonding.txt | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
>diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt
>index 91df678..83b44c2 100644
>--- a/Documentation/networking/bonding.txt
>+++ b/Documentation/networking/bonding.txt
>@@ -196,6 +196,20 @@ or, for backwards compatibility, the option value. E.g.,
>
> The parameters are as follows:
>
>+active_slave
>+
>+ Specifies the active slave for modes that support it (active-backup,
>+ balance-alb and balance-tlb). The possible values are one of the
>+ currently enslaved slaves. The selected slave must be up and the
>+ underlying link must be up too.
I would phrase this a bit differently, also including the empty
string as a possible value:
Specifies the new active slave for modes that support it
(active-backup, balance-alb and balance-tlb). Possible values
are the name of any currently enslaved interface, or an empty
string. If a name is given, the slave must be up in order to be
selected as the new active slave. If an empty string is
specified, the current active slave is cleared, and a new active
slave is selected automatically.
>+ Note that this is only available through the sysfs interface. No module
>+ parameter by that name exists.
"by this name" instead of "that".
>+ The default value is empty (no active slave). It will automatically be
>+ set every time an active slave is selected by normal bonding operation.
>+ The current active slave can be read from this sysfs entry.
I'd write this as:
The normal value of this option is the name of the currently
active slave, or the empty string if there is no active slave or
the current mode does not use an active slave.
With the above changes (or something pretty much equivalent) I'm
good with this, and you can add a signed-off for me.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bonding: document undocumented active_slave sysfs entry.
2011-12-26 21:10 ` Jay Vosburgh
@ 2011-12-26 22:51 ` Nicolas de Pesloüan
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas de Pesloüan @ 2011-12-26 22:51 UTC (permalink / raw)
To: Jay Vosburgh; +Cc: Nicolas de Pesloüan, netdev, Andy Gospodarek
Le 26/12/2011 22:10, Jay Vosburgh a écrit :
> Nicolas de Pesloüan <nicolas.2p.debian@free.fr> wrote:
>
>> Signed-off-by: Nicolas de Pesloüan<nicolas.2p.debian@free.fr>
>> cc: Jay Vosburgh<fubar@us.ibm.com>
>> cc: Andy Gospodarek<andy@greyhouse.net>
>>
>> ---
>> Documentation/networking/bonding.txt | 14 ++++++++++++++
>> 1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt
>> index 91df678..83b44c2 100644
>> --- a/Documentation/networking/bonding.txt
>> +++ b/Documentation/networking/bonding.txt
>> @@ -196,6 +196,20 @@ or, for backwards compatibility, the option value. E.g.,
>>
>> The parameters are as follows:
>>
>> +active_slave
>> +
>> + Specifies the active slave for modes that support it (active-backup,
>> + balance-alb and balance-tlb). The possible values are one of the
>> + currently enslaved slaves. The selected slave must be up and the
>> + underlying link must be up too.
>
> I would phrase this a bit differently, also including the empty
> string as a possible value:
>
> Specifies the new active slave for modes that support it
> (active-backup, balance-alb and balance-tlb). Possible values
> are the name of any currently enslaved interface, or an empty
> string. If a name is given, the slave must be up in order to be
> selected as the new active slave. If an empty string is
> specified, the current active slave is cleared, and a new active
> slave is selected automatically.
>
>> + Note that this is only available through the sysfs interface. No module
>> + parameter by that name exists.
>
> "by this name" instead of "that".
>
>> + The default value is empty (no active slave). It will automatically be
>> + set every time an active slave is selected by normal bonding operation.
>> + The current active slave can be read from this sysfs entry.
>
> I'd write this as:
>
> The normal value of this option is the name of the currently
> active slave, or the empty string if there is no active slave or
> the current mode does not use an active slave.
>
> With the above changes (or something pretty much equivalent) I'm
> good with this, and you can add a signed-off for me.
Thanks for the review. I will send V2 later.
Nicolas.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] bonding: document undocumented active_slave sysfs entry.
2011-12-26 12:19 [PATCH] bonding: document undocumented active_slave sysfs entry Nicolas de Pesloüan
2011-12-26 20:20 ` David Miller
2011-12-26 21:10 ` Jay Vosburgh
@ 2011-12-26 23:35 ` Nicolas de Pesloüan
2011-12-27 1:09 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Nicolas de Pesloüan @ 2011-12-26 23:35 UTC (permalink / raw)
To: netdev; +Cc: Nicolas de Pesloüan, Jay Vosburgh, Andy Gospodarek
v2, based on Jay's review.
I kept the 'link must be up' part, because this is enforced in the code.
Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
cc: Andy Gospodarek <andy@greyhouse.net>
---
Documentation/networking/bonding.txt | 17 +++++++++++++++++
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt
index 91df678..067e715 100644
--- a/Documentation/networking/bonding.txt
+++ b/Documentation/networking/bonding.txt
@@ -196,6 +196,23 @@ or, for backwards compatibility, the option value. E.g.,
The parameters are as follows:
+active_slave
+
+ Specifies the new active slave for modes that support it
+ (active-backup, balance-alb and balance-tlb). Possible values
+ are the name of any currently enslaved interface, or an empty
+ string. If a name is given, the slave and its link must be up in order
+ to be selected as the new active slave. If an empty string is
+ specified, the current active slave is cleared, and a new active
+ slave is selected automatically.
+
+ Note that this is only available through the sysfs interface. No module
+ parameter by this name exists.
+
+ The normal value of this option is the name of the currently
+ active slave, or the empty string if there is no active slave or
+ the current mode does not use an active slave.
+
ad_select
Specifies the 802.3ad aggregation selection logic to use. The
--
1.7.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] bonding: document undocumented active_slave sysfs entry.
2011-12-26 23:35 ` [PATCH V2] " Nicolas de Pesloüan
@ 2011-12-27 1:09 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-12-27 1:09 UTC (permalink / raw)
To: nicolas.2p.debian; +Cc: netdev, fubar, andy
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Date: Tue, 27 Dec 2011 00:35:24 +0100
> v2, based on Jay's review.
>
> I kept the 'link must be up' part, because this is enforced in the code.
>
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> cc: Andy Gospodarek <andy@greyhouse.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-27 1:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-26 12:19 [PATCH] bonding: document undocumented active_slave sysfs entry Nicolas de Pesloüan
2011-12-26 20:20 ` David Miller
2011-12-26 21:10 ` Jay Vosburgh
2011-12-26 22:51 ` Nicolas de Pesloüan
2011-12-26 23:35 ` [PATCH V2] " Nicolas de Pesloüan
2011-12-27 1:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).