From: Rob Herring <rob.herring@calxeda.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency
Date: Tue, 27 Dec 2011 08:16:07 -0600 [thread overview]
Message-ID: <4EF9D327.3070808@calxeda.com> (raw)
In-Reply-To: <1324994825-4197-1-git-send-email-heiko.carstens@de.ibm.com>
On 12/27/2011 08:07 AM, Heiko Carstens wrote:
> Fix allyesconfig build on architectures without IOMEM:
>
> drivers/net/ethernet/calxeda/xgmac.c:1800:2:
> error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
Thanks.
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/net/ethernet/calxeda/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/calxeda/Kconfig b/drivers/net/ethernet/calxeda/Kconfig
> index a52e725..aba435c 100644
> --- a/drivers/net/ethernet/calxeda/Kconfig
> +++ b/drivers/net/ethernet/calxeda/Kconfig
> @@ -1,6 +1,6 @@
> config NET_CALXEDA_XGMAC
> tristate "Calxeda 1G/10G XGMAC Ethernet driver"
> -
> + depends on HAS_IOMEM
> select CRC32
> help
> This is the driver for the XGMAC Ethernet IP block found on Calxeda
next prev parent reply other threads:[~2011-12-27 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 14:07 [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency Heiko Carstens
2011-12-27 14:16 ` Rob Herring [this message]
2011-12-27 18:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF9D327.3070808@calxeda.com \
--to=rob.herring@calxeda.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).