netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency
@ 2011-12-27 14:07 Heiko Carstens
  2011-12-27 14:16 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2011-12-27 14:07 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, linux-kernel, Heiko Carstens, Rob Herring

Fix allyesconfig build on architectures without IOMEM:

drivers/net/ethernet/calxeda/xgmac.c:1800:2:
  error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Rob Herring <rob.herring@calxeda.com>
---
 drivers/net/ethernet/calxeda/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/calxeda/Kconfig b/drivers/net/ethernet/calxeda/Kconfig
index a52e725..aba435c 100644
--- a/drivers/net/ethernet/calxeda/Kconfig
+++ b/drivers/net/ethernet/calxeda/Kconfig
@@ -1,6 +1,6 @@
 config NET_CALXEDA_XGMAC
 	tristate "Calxeda 1G/10G XGMAC Ethernet driver"
-
+	depends on HAS_IOMEM
 	select CRC32
 	help
 	  This is the driver for the XGMAC Ethernet IP block found on Calxeda
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency
  2011-12-27 14:07 [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency Heiko Carstens
@ 2011-12-27 14:16 ` Rob Herring
  2011-12-27 18:01   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2011-12-27 14:16 UTC (permalink / raw)
  To: Heiko Carstens; +Cc: David S. Miller, netdev, linux-kernel

On 12/27/2011 08:07 AM, Heiko Carstens wrote:
> Fix allyesconfig build on architectures without IOMEM:
> 
> drivers/net/ethernet/calxeda/xgmac.c:1800:2:
>   error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Rob Herring <rob.herring@calxeda.com>

Thanks.

Acked-by: Rob Herring <rob.herring@calxeda.com>

> ---
>  drivers/net/ethernet/calxeda/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/calxeda/Kconfig b/drivers/net/ethernet/calxeda/Kconfig
> index a52e725..aba435c 100644
> --- a/drivers/net/ethernet/calxeda/Kconfig
> +++ b/drivers/net/ethernet/calxeda/Kconfig
> @@ -1,6 +1,6 @@
>  config NET_CALXEDA_XGMAC
>  	tristate "Calxeda 1G/10G XGMAC Ethernet driver"
> -
> +	depends on HAS_IOMEM
>  	select CRC32
>  	help
>  	  This is the driver for the XGMAC Ethernet IP block found on Calxeda

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency
  2011-12-27 14:16 ` Rob Herring
@ 2011-12-27 18:01   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-12-27 18:01 UTC (permalink / raw)
  To: rob.herring; +Cc: heiko.carstens, netdev, linux-kernel

From: Rob Herring <rob.herring@calxeda.com>
Date: Tue, 27 Dec 2011 08:16:07 -0600

> On 12/27/2011 08:07 AM, Heiko Carstens wrote:
>> Fix allyesconfig build on architectures without IOMEM:
>> 
>> drivers/net/ethernet/calxeda/xgmac.c:1800:2:
>>   error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
>> 
>> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>> Cc: Rob Herring <rob.herring@calxeda.com>
> 
> Thanks.
> 
> Acked-by: Rob Herring <rob.herring@calxeda.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-12-27 18:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-27 14:07 [PATCH -next] net: calxeda xgmac ethernet driver add missing HAS_IOMEM dependency Heiko Carstens
2011-12-27 14:16 ` Rob Herring
2011-12-27 18:01   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).