From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6B9C43387 for ; Wed, 16 Jan 2019 17:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D587B2082F for ; Wed, 16 Jan 2019 17:49:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="fRoljEPU"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="Xwcu0XjW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727619AbfAPRtG (ORCPT ); Wed, 16 Jan 2019 12:49:06 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:59660 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727556AbfAPRtG (ORCPT ); Wed, 16 Jan 2019 12:49:06 -0500 Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0GHcwPJ029096; Wed, 16 Jan 2019 09:48:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=z1CsjiBNH/Zc9xhFa7Uo/cmLn/ROLBjPP3l24AM9SNs=; b=fRoljEPU06uOnP7g372J/Nx0LgT5LqyYPQJJ+bsVU57t6QSw6hBNUHL+yl7yZaDUM9S0 08bokmT7a+m4B5MAyMospgRrUWF41uPIB99dTsTfRlTYyg2W0x9c/LeFS4gNzAJwOqWJ /69zR8lRpfv9GhiC4rgyyYQ4jKhRmc3xxqY= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2q260frt4x-7 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 16 Jan 2019 09:48:51 -0800 Received: from frc-mbx05.TheFacebook.com (2620:10d:c0a1:f82::29) by frc-hub01.TheFacebook.com (2620:10d:c021:18::171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Wed, 16 Jan 2019 09:48:50 -0800 Received: from frc-hub04.TheFacebook.com (2620:10d:c021:18::174) by frc-mbx05.TheFacebook.com (2620:10d:c0a1:f82::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Wed, 16 Jan 2019 09:48:50 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3 via Frontend Transport; Wed, 16 Jan 2019 09:48:50 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z1CsjiBNH/Zc9xhFa7Uo/cmLn/ROLBjPP3l24AM9SNs=; b=Xwcu0XjWWqp+8fGH17/ToWzANFv9BZWp93dqC/o131WCidOIH/ny08pag0chi3T/gPYtCSpni64S1vuwhK8t6LPaZpEE4gP59jEH60hKIeYG3C3th2kdf9VU4ZC/ZXzLfGxoEI8VNkhU44CBeFXEpT6BaPoXDS05kUPq2a6kIAg= Received: from MWHPR15MB1165.namprd15.prod.outlook.com (10.175.2.19) by MWHPR15MB1773.namprd15.prod.outlook.com (10.174.255.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.25; Wed, 16 Jan 2019 17:48:48 +0000 Received: from MWHPR15MB1165.namprd15.prod.outlook.com ([fe80::ec0e:4a05:81f8:7df9]) by MWHPR15MB1165.namprd15.prod.outlook.com ([fe80::ec0e:4a05:81f8:7df9%4]) with mapi id 15.20.1537.018; Wed, 16 Jan 2019 17:48:48 +0000 From: Song Liu To: Stanislav Fomichev CC: Netdev , "davem@davemloft.net" , "ast@kernel.org" , "daniel@iogearbox.net" Subject: Re: [PATCH bpf 2/3] bpf: zero out build_id for BPF_STACK_BUILD_ID_IP Thread-Topic: [PATCH bpf 2/3] bpf: zero out build_id for BPF_STACK_BUILD_ID_IP Thread-Index: AQHUrSV1hK65OVnjXku85ZJJrQpRfqWyLSuA Date: Wed, 16 Jan 2019 17:48:48 +0000 Message-ID: <4EFF086F-81EB-48BE-AC78-F8DB8B29003F@fb.com> References: <20190115225447.245788-1-sdf@google.com> <20190115225447.245788-2-sdf@google.com> In-Reply-To: <20190115225447.245788-2-sdf@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3445.102.3) x-originating-ip: [2620:10d:c090:180::1:2ea9] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR15MB1773;20:9cdX/2m+ZnesX1pgFtGa3oLYmOpLjW+iSi3zN0oSkJGYr14ToC0ye8DaeMYzF6ydTOeBsWuCsoLgIEwkx+rVROT6BeI93PY596GZFKI0dhdy7NW3wcNQltTnkg9xcn1BhpYGVcfsGmhasImuUMCrWwVO2+uZOOquorHutu8UGqM= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 29a855a1-aed7-4176-e42d-08d67bdadeb0 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020);SRVR:MWHPR15MB1773; x-ms-traffictypediagnostic: MWHPR15MB1773: x-microsoft-antispam-prvs: x-forefront-prvs: 091949432C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(366004)(376002)(136003)(39860400002)(396003)(189003)(199004)(476003)(4326008)(229853002)(2616005)(11346002)(6512007)(8936002)(46003)(6486002)(57306001)(478600001)(256004)(8676002)(81166006)(81156014)(446003)(105586002)(97736004)(53936002)(6436002)(5660300001)(6246003)(82746002)(86362001)(14454004)(6916009)(25786009)(36756003)(106356001)(68736007)(71190400001)(83716004)(71200400001)(53546011)(6506007)(102836004)(305945005)(50226002)(186003)(6116002)(2906002)(99286004)(316002)(54906003)(76176011)(7736002)(486006)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1773;H:MWHPR15MB1165.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Mwe4hjtcOD5ljMgy2Kczv+jxaXzmnzsiMDNFAUEJSZrCA2KvqvG+x2Ii2+PD/bkVCWcF7NlWLRtohs+dIszy0Ksu591N6MTDHR4AvNRAnv0y/RzGU8s2TxF7JaLEdHOTyJXeGeMG3YWZBuQTciNs5hG/2cSmqFjGo5h3XtYDo/LJHZfkwOnwyp0fkocrM/LB7qrNhw95I+kEG+69MJEpvks+dHg15IGrC+iXmlvT+QDK2x7EZFZd/CFScncxM/+TGEqTJCcnH0R+knE66KKHzTUHBpEe5xzI3uuNjD0sSky8gBfhEHd/5eGyOb1/v+9jTswluyZYqLKhRf0nzp6BJ5mLHlTGhKDfm0qw7HXo6Ur80akqGSWrhqq1r2fAWVX1afNsCQhtS965xZyDx2I3CT1eYO45Rnzxs5QNIGQ4VkM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 29a855a1-aed7-4176-e42d-08d67bdadeb0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2019 17:48:48.6513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1773 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-16_07:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > On Jan 15, 2019, at 2:54 PM, Stanislav Fomichev wrote: >=20 > When returning BPF_STACK_BUILD_ID_IP from stack_map_get_build_id_offset, > make sure that build_id field is empty. Since we are using percpu > free list, there is a possibility that we might reuse some previous > bpf_stack_build_id with non-zero build_id. >=20 > Fixes: 615755a77b24 ("bpf: extend stackmap to save binary_build_id+offset= instead of address") > Signed-off-by: Stanislav Fomichev Acked-by: Song Liu > --- > kernel/bpf/stackmap.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c > index 8975d1768dcb..f4b57c68c45f 100644 > --- a/kernel/bpf/stackmap.c > +++ b/kernel/bpf/stackmap.c > @@ -315,6 +315,7 @@ static void stack_map_get_build_id_offset(struct bpf_= stack_build_id *id_offs, > for (i =3D 0; i < trace_nr; i++) { > id_offs[i].status =3D BPF_STACK_BUILD_ID_IP; > id_offs[i].ip =3D ips[i]; > + memset(id_offs[i].build_id, 0, BPF_BUILD_ID_SIZE); > } > return; > } > @@ -325,6 +326,7 @@ static void stack_map_get_build_id_offset(struct bpf_= stack_build_id *id_offs, > /* per entry fall back to ips */ > id_offs[i].status =3D BPF_STACK_BUILD_ID_IP; > id_offs[i].ip =3D ips[i]; > + memset(id_offs[i].build_id, 0, BPF_BUILD_ID_SIZE); > continue; > } > id_offs[i].offset =3D (vma->vm_pgoff << PAGE_SHIFT) + ips[i] > --=20 > 2.20.1.97.g81188d93c3-goog >=20