From: Larry Finger <Larry.Finger@lwfinger.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Joe Perches <joe@perches.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] rtlwifi: Standardize RT_PRINT_DATA macro and uses
Date: Thu, 05 Jan 2012 09:54:51 -0600 [thread overview]
Message-ID: <4F05C7CB.3000607@lwfinger.net> (raw)
In-Reply-To: <20120105114314.GD2222@redhat.com>
On 01/05/2012 05:43 AM, Stanislaw Gruszka wrote:
> Hi Joe
>
> On Wed, Jan 04, 2012 at 07:40:40PM -0800, Joe Perches wrote:
>> RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_DMESG,
>
> Since you are working on it, can you also get rid of this DBG_*
> parameter, if rtlwifi maintainers are ok with that? It is additional
> console loglvevel, standard kernel loglevel should be used.
I'm not OK with that. Those DBG_* parameters are used in conjunction with a
load-time debug parameter to set the level of debugging. You could rename all of
them, but that would be useless churning of the source with no real value.
Larry
next prev parent reply other threads:[~2012-01-05 15:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 3:40 [PATCH 0/7] rtlwifi: debug macros and uses neatening Joe Perches
2012-01-05 3:40 ` [PATCH 1/7] rtlwifi: Neaten RT_ASSERT, RT_TRACE, RTPRINT, RT_PRINT_DATA macros Joe Perches
2012-01-05 11:25 ` David Laight
2012-01-05 3:40 ` [PATCH 2/7] rtlwifi: Standardize RT_PRINT_DATA macro and uses Joe Perches
2012-01-05 11:43 ` Stanislaw Gruszka
2012-01-05 15:54 ` Larry Finger [this message]
2012-01-05 16:29 ` Joe Perches
2012-01-05 16:44 ` Larry Finger
2012-01-05 16:54 ` Joe Perches
2012-01-05 3:40 ` [PATCH 3/7] rtlwifi: Convert RT_TRACE macro to use ##__VA_ARGS__ Joe Perches
2012-01-05 3:40 ` [PATCH 4/7] rtlwifi: Convert RTPRINT " Joe Perches
2012-01-05 3:40 ` [PATCH 5/7] rtlwifi: Convert RT_ASSERT " Joe Perches
[not found] ` <cover.1325734202.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2012-01-05 3:40 ` [PATCH 6/7] rtlwifi: Remove duplicate __func__ Joe Perches
2012-01-05 3:40 ` [PATCH 7/7] rtlwifi: Optimize RT_TRACE macro use of KBUILD_MODNAME for size Joe Perches
2012-01-05 19:03 ` [PATCH 0/7] rtlwifi: debug macros and uses neatening Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F05C7CB.3000607@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).