From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Subject: Re: [PATCH 2/7] rtlwifi: Standardize RT_PRINT_DATA macro and uses Date: Thu, 05 Jan 2012 09:54:51 -0600 Message-ID: <4F05C7CB.3000607@lwfinger.net> References: <20120105114314.GD2222@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Joe Perches , Chaoming Li , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Stanislaw Gruszka Return-path: In-Reply-To: <20120105114314.GD2222@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 01/05/2012 05:43 AM, Stanislaw Gruszka wrote: > Hi Joe > > On Wed, Jan 04, 2012 at 07:40:40PM -0800, Joe Perches wrote: >> RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_DMESG, > > Since you are working on it, can you also get rid of this DBG_* > parameter, if rtlwifi maintainers are ok with that? It is additional > console loglvevel, standard kernel loglevel should be used. I'm not OK with that. Those DBG_* parameters are used in conjunction with a load-time debug parameter to set the level of debugging. You could rename all of them, but that would be useless churning of the source with no real value. Larry