From: Maxim Uvarov <maxim.uvarov@oracle.com>
To: Andy Gospodarek <gospo@redhat.com>
Cc: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net,
davem@davemloft.net, Cong Wang <amwang@redhat.com>
Subject: Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit
Date: Mon, 09 Jan 2012 19:09:32 -0800 [thread overview]
Message-ID: <4F0BABEC.2050200@oracle.com> (raw)
In-Reply-To: <20120109222046.GC32485@quad.redhat.com>
On 01/09/2012 02:20 PM, Andy Gospodarek wrote:
> On Mon, Jan 09, 2012 at 02:01:37PM -0800, Maxim Uvarov wrote:
>> No need to lock soft irqs under bond_alb_xmit()
>> which already has softirq disabled.
>>
>> Changes:
>> 1. add non-bh/bh version to tlb_clear_slave()
>>
>> 2. represent BH and non BH hash table locks
>> _lock_rx_hashtbl_bh/_unlock_rx_hashtbl_bh
>> _lock_rx_hashtbl/_unlock_rx_hashtbl
>> _lock_tx_hashtbl_bh/_unlock_tx_hashtbl_bh
>> _lock_tx_hashtbl/_unlock_tx_hashtbl
>>
>> Signed-off-by: Maxim Uvarov<maxim.uvarov@oracle.com>
>> Signed-off-by: Cong Wang<amwang@redhat.com>
>> ---
>> drivers/net/bonding/bond_alb.c | 112 +++++++++++++++++++++++++++-------------
>> 1 files changed, 76 insertions(+), 36 deletions(-)
>>
>
> Did you test this with CONFIG_DEBUG_LOCKDEP=y at all?
>
Just did some simple tests on bond0 with LOCKDEP. Do not see any warnings.
Maxim.
next prev parent reply other threads:[~2012-01-10 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:01 [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit Maxim Uvarov
2012-01-09 22:20 ` Andy Gospodarek
2012-01-10 3:09 ` Maxim Uvarov [this message]
2012-01-10 17:52 ` Andy Gospodarek
2012-01-11 20:52 ` David Miller
2012-01-11 21:26 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0BABEC.2050200@oracle.com \
--to=maxim.uvarov@oracle.com \
--cc=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).