From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: "Cloutier, Joseph (Joseph)" <joseph.cloutier@alcatel-lucent.com>
Cc: "'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
'Linus Torvalds' <torvalds@linux-foundation.org>
Subject: Re: "-w deadline" bug in ping/iputils- i will provide fix if you can tell me where owner of iputils is. Thanks.
Date: Tue, 10 Jan 2012 12:54:47 +0900 [thread overview]
Message-ID: <4F0BB687.6070603@linux-ipv6.org> (raw)
In-Reply-To: <7D3B6706FA74174B8C1AC24710890745136F453C33@USNAVSXCHMBSA1.ndc.alcatel-lucent.com>
Hello.
Cloutier, Joseph (Joseph) wrote:
> I have made a fix for the "-w deadline" issue to iputils-s20101006.tar.bz2. There are 4 places in the code with the fix, identified by my name, Joe Cloutier- ALU.
>>
>> There are 2 bugs fixed:
>> * For flood pings if the "-w" option is set then more pings than "-c x" are sent out.
>> * The "-w x" timer should be set after he last "-c x" ping is sent out.
Is this a real bug?
If both of -c COUNT and -w TIMEOUT are specified, ping exits by
timer _OR_ by the counter regardless of -f option.
If you want to ping really COUNT times, try -W TIMEOUT option.
... And please send your changes in the patch (or unified diff;
diff -u) format with your appropriate "sign-off" line, next time.
Thanks.
--yoshfuji
next prev parent reply other threads:[~2012-01-10 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7D3B6706FA74174B8C1AC24710890745136F1A0BF1@USNAVSXCHMBSA1.ndc.alcatel-lucent.com>
2012-01-04 20:56 ` "-w deadline" bug in ping/iputils- i will provide fix if you can tell me where owner of iputils is. Thanks Cloutier, Joseph (Joseph)
2012-01-09 15:45 ` YOSHIFUJI Hideaki
2012-01-09 17:26 ` Cloutier, Joseph (Joseph)
2012-01-10 3:54 ` YOSHIFUJI Hideaki [this message]
2012-01-10 18:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0BB687.6070603@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=joseph.cloutier@alcatel-lucent.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).