From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH 0/5] NFS: create blocklayout pipe per network namesapce context Date: Wed, 11 Jan 2012 21:23:14 +0400 Message-ID: <4F0DC582.6030805@parallels.com> References: <20111129090754.20730.64567.stgit@localhost6.localdomain6> <1325285705.10984.4.camel@lade.trondhjem.org> <1325797111.11084.22.camel@lade.trondhjem.org> <4F0C35F3.7060508@parallels.com> <1326299003.17212.7.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "bfields@fieldses.org" , "davem@davemloft.net" , "devel@openvz.org" To: Trond Myklebust Return-path: In-Reply-To: <1326299003.17212.7.camel@lade.trondhjem.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org 11.01.2012 20:23, Trond Myklebust =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Tue, 2012-01-10 at 16:58 +0400, Stanislav Kinsbursky wrote: >> 06.01.2012 00:58, Trond Myklebust =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> The second problem that was highlighted was the fact that as they s= tand >>> today, these patchsets do not allow for bisection. When we hit the = Oops, >>> I had Bryan try to bisect where the problem arose. He ended up poin= ting >>> at the patch "SUNRPC: handle RPC client pipefs dentries by network >>> namespace aware routine", which is indeed the cause, but which is o= ne of >>> the _dependencies_ for all the PipeFS notifier patches that fix the >>> problem. >>> >> >> I'm confused here. Does this means, that I have to fix patch "SUNRPC= : handle RPC >> client pipefs dentries by network namespace aware routine" to make i= t able to >> bisect? > > What I mean is that currently, I have various ways to Oops the kernel > when I apply "SUNRPC: handle RPC client pipefs dentries by network > namespace aware routine" before all these other followup patches are > applied. > > One way to could fix this, might be to add dummy versions of > rpc_pipefs_notifier_register()/unregister() so that "NFS: idmap PipeF= S > notifier introduced" and the other such patches can be applied withou= t > compilation errors or Oopses before the "handle RPC client pipefs > dentries..." patch is applied. The latter could then enable the real > rpc_pipefs_notifier_register()/.... > > The point is to not have these patches add _known_ bugs to the kernel= at > any point, so that someone who is trying to track down an unknown bug > via "git bisect" doesn't have to also cope with these avoidable > issues... > Ok, thanks for explanation. I've sent rebased "v2" of the patch set, contains updated patch "SUNRPC= : handle=20 RPC client pipefs dentries by network namespace aware routine", which, = I=20 believe, fixes oops, spotted by Bryan (it was caused by excessive call = of=20 rpc_put_mount() on PipeFS dentries unlink). So, if I'm not mistaken here, there's no need in implementing of dummy = versions=20 of rpc_pipefs_notifier_(un)register() or any other dummy stuff. BTW, it looks like that in last 2 days I've sent all updates to the iss= ues you=20 pointed out. If not, please, ping me once more. --=20 Best regards, Stanislav Kinsbursky