From: "Arend van Spriel" <arend@broadcom.com>
To: "Larry Finger" <Larry.Finger@lwfinger.net>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"John W. Linville" <linville@tuxdriver.com>,
"Network Development" <netdev@vger.kernel.org>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: brcm80211 breakage..
Date: Thu, 12 Jan 2012 14:13:25 +0100 [thread overview]
Message-ID: <4F0EDC75.3040003@broadcom.com> (raw)
In-Reply-To: <4F0E5E57.9060204@lwfinger.net>
On 01/12/2012 05:15 AM, Larry Finger wrote:
> On 01/11/2012 08:11 PM, Linus Torvalds wrote:
>> On Wed, Jan 11, 2012 at 5:46 PM, Larry Finger<Larry.Finger@lwfinger.net> wrote:
>>>
>>> OK. The SPROM issue is not completely irrelevant as that has to be correct,
>>> but obviously not sufficient.
>>
>> Hmm. Having dug a bit deeper, I do think it's kind of related.
>>
>> I get -ENODATA form sprom_read_pci(), but that function actually seems
>> to get the offset *right*.
>>
>> Some printout shows that for that chip, I have
>>
>> - ai_get_ccrev(sih) = 34
>> - sprom_offset = 0x800
>>
>> but then it apparently reads all ones anyway. At least in the first
>> word. So then I get that -ENODATA error.
>>
>> So once more, it's somehow related to the sprom, just in a new place:
>> sprom_read_pci() in brcmsmac/srom.c instead of drivers/bcma/sprom.c.
>>
>> Does that give people any new ideas to try out?
>
> Things are getting curious. I have a 14e4:4353 device, which works with both b43
> and brcmsmac using mainline v3.2-6271-g925b5d2. The output of
>
> dmesg | egrep "bcma|brcm"
>
> with some extra debugging added yields:
>
> bcma-pci-bridge 0000:06:00.0: PCI INT A -> Link[LK1E] -> GSI 22 (level, low) ->
> IRQ 22
> bcma-pci-bridge 0000:06:00.0: setting latency timer to 64
> bcma: Core 0 found: ChipCommon (manuf 0x4BF, id 0x800, rev 0x22, class 0x0)
> bcma: Core 1 found: IEEE 802.11 (manuf 0x4BF, id 0x812, rev 0x17, class 0x0)
> bcma: Core 2 found: PCIe (manuf 0x4BF, id 0x820, rev 0x0F, class 0x0)
> bcma: Found rev 6 PMU (capabilities 0x108C2606)
> bcma: SPROM offset 0x830
> bcma: Found SPROM Revision 8
> bcma: Bus registered
> brcmsmac bcma0:0: mfg 4bf core 812 rev 23 class 0 irq 22
> brcmsmac: Found chip type AI (0x1381a8d8)
> brcmsmac: Applying 43224B0+ WARs
> bcma: Switched to core: 0x812
> brcms_module_init: register returned 0
>
> I see no difference in the core revisions, etc. to explain why mine should work,
> and yours fail.
>
> Arend: Any particular place we should look?
>
> Larry
>
Hi, Larry
I am surprised that we end up on sprom_read_pci(). That suggests that
MacBook Air has an external sprom. Can you tell me what the function
ai_is_sprom_available() returns on your system?
Gr. AvS
next prev parent reply other threads:[~2012-01-12 13:13 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 20:15 brcm80211 breakage Linus Torvalds
2012-01-11 10:44 ` Arend van Spriel
2012-01-11 15:05 ` Linus Torvalds
2012-01-11 16:04 ` Linus Torvalds
2012-01-11 17:00 ` Larry Finger
2012-01-12 1:06 ` Linus Torvalds
2012-01-12 1:46 ` Larry Finger
2012-01-12 1:58 ` Linus Torvalds
2012-01-12 2:11 ` Linus Torvalds
2012-01-12 4:15 ` Larry Finger
2012-01-12 5:20 ` Linus Torvalds
2012-01-12 5:30 ` Linus Torvalds
2012-01-12 7:08 ` Rafał Miłecki
2012-01-12 7:10 ` Rafał Miłecki
2012-01-12 7:18 ` Linus Torvalds
2012-01-12 15:39 ` Larry Finger
2012-01-12 15:46 ` Rafał Miłecki
2012-01-12 7:13 ` Linus Torvalds
2012-01-12 7:18 ` Rafał Miłecki
2012-01-12 7:22 ` Linus Torvalds
2012-01-12 10:03 ` Arend van Spriel
2012-01-12 15:51 ` Linus Torvalds
2012-01-12 19:00 ` Linus Torvalds
2012-01-12 19:08 ` Linus Torvalds
2012-01-12 20:09 ` Arend van Spriel
2012-01-12 20:27 ` Linus Torvalds
2012-01-12 20:36 ` Arend van Spriel
2012-01-12 22:38 ` Linus Torvalds
2012-01-12 22:42 ` Rafał Miłecki
2012-01-12 22:45 ` Linus Torvalds
2012-01-12 23:04 ` Rafał Miłecki
2012-01-13 0:13 ` Linus Torvalds
2012-01-13 2:30 ` Linus Torvalds
2012-01-13 5:34 ` Linus Torvalds
2012-01-13 6:50 ` Rafał Miłecki
2012-01-13 6:57 ` Rafał Miłecki
2012-01-13 7:17 ` Linus Torvalds
2012-01-13 7:41 ` [PATCH] bcma: s&r: NULL mapped core Rafał Miłecki
2012-01-13 7:53 ` Linus Torvalds
2012-01-13 7:59 ` [0/5] bcma/brcmsmac suspend/resume cleanups and fixes Linus Torvalds
2012-01-13 8:00 ` [PATCH 1/5] bcma: convert suspend/resume to pm_ops Linus Torvalds
2012-01-13 9:58 ` Arend van Spriel
2012-01-13 10:01 ` Rafał Miłecki
2012-01-13 8:00 ` [PATCH 2/5] bcma: add stub for bcma_bus suspend() Linus Torvalds
2012-01-13 8:01 ` [PATCH 3/5] bcma: connect the bcma bus suspend/resume to the bcma driver suspend/resume Linus Torvalds
2012-01-13 8:01 ` [PATCH 4/5] brcmsmac: remove PCI suspend/resume from bcma driver Linus Torvalds
2012-01-13 9:59 ` Arend van Spriel
2012-01-13 8:02 ` [PATCH 5/5] bcma: invalidate the mapped window over suspend/resume Linus Torvalds
2012-01-13 10:03 ` [0/5] bcma/brcmsmac suspend/resume cleanups and fixes Rafał Miłecki
2012-01-13 16:15 ` Linus Torvalds
2012-01-13 11:06 ` Arend van Spriel
2012-01-13 16:23 ` Linus Torvalds
2012-01-14 3:50 ` Linus Torvalds
2012-01-14 12:22 ` Dominique Martinet
2012-01-14 14:34 ` Rafał Miłecki
2012-01-14 15:07 ` Dominique Martinet
2012-01-14 19:15 ` Linus Torvalds
2012-01-14 23:08 ` Dominique Martinet
2012-01-14 23:28 ` Linus Torvalds
2012-01-14 17:36 ` Arend van Spriel
2012-01-16 14:00 ` Arend van Spriel
2012-01-16 17:33 ` Arend van Spriel
2012-01-17 1:12 ` Linus Torvalds
2012-01-17 10:37 ` Arend van Spriel
2012-01-19 9:42 ` Arend van Spriel
2012-01-19 12:12 ` Arend van Spriel
2012-01-19 16:15 ` Linus Torvalds
2012-01-13 7:13 ` brcm80211 breakage Linus Torvalds
2012-01-12 19:46 ` Arend van Spriel
2012-01-13 1:53 ` Larry Finger
2012-01-31 12:08 ` Henrik Rydberg
2012-01-31 17:02 ` Linus Torvalds
2012-01-31 19:08 ` Arend van Spriel
2012-01-31 19:25 ` John W. Linville
2012-01-31 19:35 ` Arend van Spriel
2012-01-31 19:58 ` Henrik Rydberg
2012-01-31 20:21 ` Arend van Spriel
2012-01-31 22:23 ` Henrik Rydberg
2012-01-31 19:36 ` Henrik Rydberg
2012-01-31 19:49 ` Arend van Spriel
2012-01-12 13:13 ` Arend van Spriel [this message]
2012-01-12 16:22 ` Larry Finger
2012-01-12 17:18 ` Larry Finger
2012-01-12 17:31 ` Linus Torvalds
2012-01-12 17:44 ` Larry Finger
2012-01-11 21:01 ` Arend van Spriel
2012-01-12 0:07 ` Linus Torvalds
2012-01-11 17:15 ` Ben Hutchings
2012-01-12 0:10 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0EDC75.3040003@broadcom.com \
--to=arend@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=frankyl@broadcom.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).