From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Arend van Spriel" Subject: Re: brcm80211 breakage.. Date: Thu, 12 Jan 2012 21:36:33 +0100 Message-ID: <4F0F4451.6080602@broadcom.com> References: <4F0D6806.4080201@broadcom.com> <4F0DC030.6090500@lwfinger.net> <4F0E3B7E.8040005@lwfinger.net> <4F0E5E57.9060204@lwfinger.net> <4F0F3DEC.4050605@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Cc: "Larry Finger" , "Alwin Beukers" , "Roland Vossen" , "John W. Linville" , "Network Development" , "Franky (Zhenhui) Lin" , =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= To: "Linus Torvalds" Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4297 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755175Ab2ALUgo (ORCPT ); Thu, 12 Jan 2012 15:36:44 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 01/12/2012 09:27 PM, Linus Torvalds wrote: > 2012/1/12 Arend van Spriel : >> >> That output look fine. The patch looks fine although you can use the new >> do_crc_check() function in otp_read_pci as well. > > I'll leave that as a separate cleanup for somebody who has the > hardware to test it. I committed the 16-bit read fix for now. Ah. yet another hint :-p > But I'm currently also trying to work out why that macbook air no > longer comes back from a suspend alive, and it looks like it may be > another problem with that brcmsmac driver. The bisection is in its > early stages yet, but it looks like it is coming in from the network > merge, and nothing else looks relevant. > > Has suspend/resume been tested exhaustively with that driver? > > Linus > BCMA introduced suspend/resume after the BCMA changes in brcmsmac so there may still be issues. Gr. AvS