From: Ben Greear <greearb@candelatech.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Francesco Ruggeri <fruggeri@aristanetworks.com>,
netdev@vger.kernel.org, Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: Race condition in ipv6 code
Date: Fri, 13 Jan 2012 09:04:46 -0800 [thread overview]
Message-ID: <4F10642E.2040302@candelatech.com> (raw)
In-Reply-To: <m1ipkgqccb.fsf@fess.ebiederm.org>
On 01/12/2012 11:40 PM, Eric W. Biederman wrote:
> So I really think the best solution to avoid the locking craziness is to
> have a wrapper that gets the value from userspace and calls
> schedule_work to get another thread to actually process the change. I
> don't see any problems with writing a helper function for that. The
> only downside with using schedule_work is that we return to userspace
> before the change has been fully installed in the kernel. I don't
> expect that would be a problem but stranger things have happened.
That sounds a bit risky to me. If something sets a value, and then
queries it, it should always show the proper result for the previous
calls.
If the queries also went through the the same sched-work queue
then maybe it would be OK.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-01-13 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 2:13 Race condition in ipv6 code Francesco Ruggeri
2012-01-12 6:31 ` Eric Dumazet
2012-01-12 6:44 ` David Miller
2012-01-12 20:48 ` Francesco Ruggeri
2012-01-13 0:11 ` Eric W. Biederman
2012-01-13 6:02 ` Eric Dumazet
2012-01-13 7:40 ` Eric W. Biederman
2012-01-13 17:04 ` Ben Greear [this message]
2012-01-14 5:46 ` Eric W. Biederman
2012-01-14 18:31 ` Ben Greear
2012-01-20 2:54 ` Eric W. Biederman
2012-01-13 1:17 ` Eric W. Biederman
2012-01-13 1:57 ` Stephen Hemminger
2012-01-13 22:02 ` Francesco Ruggeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F10642E.2040302@candelatech.com \
--to=greearb@candelatech.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fruggeri@aristanetworks.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).