From: Tore Anderson <tore@fud.no>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: Bugzilla 42595
Date: Wed, 18 Jan 2012 20:26:09 +0100 [thread overview]
Message-ID: <4F171CD1.8070401@fud.no> (raw)
In-Reply-To: <1326901345.2316.27.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
* Eric Dumazet
> Following patch is a good compromise, since it disables gso on the
> socket on the first frame we consider too big in ip6_fragment().
>
> So the added check on dst_allfrag() is only done once per socket,
> instead of adding in sk_can_gso(sk) in fast path.
>
> I can now let gso on on the device, and still have good transfert speed
> on sockets hitting the ALLFRAG feature.
I can both confirm that I too saw abysmal performance when using the
default offload settings (with your two earlier patches applied only),
and also that applying this patch in addition fixes the problem, with no
apparent ill effects. Thanks!
Best regards,
--
Tore Anderson
prev parent reply other threads:[~2012-01-18 19:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 16:28 [RFC] ipv6: dst_allfrag() not taken into account by TCP Eric Dumazet
2012-01-17 17:34 ` David Miller
2012-01-17 18:15 ` Eric Dumazet
2012-01-17 18:25 ` David Miller
2012-01-17 20:03 ` Tore Anderson
2012-01-17 20:25 ` Eric Dumazet
2012-01-18 12:42 ` Tore Anderson
2012-01-18 14:06 ` Eric Dumazet
2012-01-18 14:43 ` Tore Anderson
2012-01-18 14:59 ` Eric Dumazet
2012-01-18 15:14 ` Tore Anderson
2012-01-18 15:40 ` Eric Dumazet
2012-01-18 17:01 ` David Miller
2012-01-17 23:43 ` Bugzilla 42595 Eric Dumazet
2012-01-18 10:58 ` Eric Dumazet
2012-01-18 13:44 ` Eric Dumazet
2012-01-18 14:20 ` Tore Anderson
2012-01-18 14:42 ` Eric Dumazet
2012-01-18 15:42 ` Eric Dumazet
2012-01-18 19:26 ` Tore Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F171CD1.8070401@fud.no \
--to=tore@fud.no \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).