From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH 3/5] SUNRPC: create GSS auth cache per network namespace Date: Thu, 19 Jan 2012 21:51:59 +0400 Message-ID: <4F18583F.1000209@parallels.com> References: <20120119144517.9957.59143.stgit@localhost6.localdomain6> <20120119144922.9957.39352.stgit@localhost6.localdomain6> <20120119163149.GD527@fieldses.org> <4F184D28.3030207@parallels.com> <20120119174002.GA2907@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "davem@davemloft.net" , "devel@openvz.org" To: "J. Bruce Fields" Return-path: In-Reply-To: <20120119174002.GA2907@fieldses.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org 19.01.2012 21:40, J. Bruce Fields =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Thu, Jan 19, 2012 at 09:04:40PM +0400, Stanislav Kinsbursky wrote: >> 19.01.2012 20:31, J. Bruce Fields =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> On Thu, Jan 19, 2012 at 06:49:23PM +0400, Stanislav Kinsbursky wrot= e: >>>> @@ -1000,6 +996,7 @@ static int svcauth_gss_handle_init(struct svc= _rqst *rqstp, >>>> struct xdr_netobj tmpobj; >>>> struct rsi *rsip, rsikey; >>>> int ret; >>>> + struct sunrpc_net *sn =3D net_generic(rqstp->rq_xprt->xpt_net, s= unrpc_net_id); >>> >>> OK, so you're getting the network namespace out of the rqstp, and, = then >>> passing it down, makes sense. And: >>> >>>> @@ -1079,6 +1076,7 @@ svcauth_gss_accept(struct svc_rqst *rqstp, _= _be32 *authp) >>>> __be32 *rpcstart; >>>> __be32 *reject_stat =3D resv->iov_base + resv->iov_len; >>>> int ret; >>>> + struct sunrpc_net *sn =3D net_generic(rqstp->rq_xprt->xpt_net, s= unrpc_net_id); >>> >>> ... same for the gss cache. Looks good. >>> >>> How do you plan to test this? >>> >> >> Do you mean something special or in general? >> Currently I validate all my chages in container by using simple test= environment. >> I would be appreciate for any hints to tests, than can help. > > The server needs to be tested after these changes, and we need to mak= e > sure the caches affected still work. > > (I suspect the gid cache code will oops if it's used after these > patches, since the table is left NULl?) > > And then we should also test in a container environment, with differe= nt > instances of mountd and rpc.svcidmapd running in each container, to > verify that the right thing happens. > Ok. I'll test server with 2-nd version of these patches tomorrow and re= ply with=20 the results. Thanks, Bruce. --=20 Best regards, Stanislav Kinsbursky