From: Richard Weinberger <richard@nod.at>
To: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: ipt_LOG: No space after prefix
Date: Sun, 22 Jan 2012 13:54:49 +0100 [thread overview]
Message-ID: <4F1C0719.1010609@nod.at> (raw)
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
Hi!
Is there no space after prefix for specific reason?
ipt_log_packet() is using this format string:
"<%d>%sIN=%s OUT=%s "
Using a prefix leads to a broken log entry like this one (prefix is "foo"):
"fooIN=eth0 OUT= ..."
I'm sure this breaks log analyzers.
I've never noticed this because I'm using prefix very seldom.
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next reply other threads:[~2012-01-22 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 12:54 Richard Weinberger [this message]
2012-01-22 14:20 ` ipt_LOG: No space after prefix Jan Engelhardt
2012-01-22 14:26 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1C0719.1010609@nod.at \
--to=richard@nod.at \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).