* ipt_LOG: No space after prefix
@ 2012-01-22 12:54 Richard Weinberger
2012-01-22 14:20 ` Jan Engelhardt
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2012-01-22 12:54 UTC (permalink / raw)
To: netfilter-devel, netdev
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
Hi!
Is there no space after prefix for specific reason?
ipt_log_packet() is using this format string:
"<%d>%sIN=%s OUT=%s "
Using a prefix leads to a broken log entry like this one (prefix is "foo"):
"fooIN=eth0 OUT= ..."
I'm sure this breaks log analyzers.
I've never noticed this because I'm using prefix very seldom.
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ipt_LOG: No space after prefix
2012-01-22 12:54 ipt_LOG: No space after prefix Richard Weinberger
@ 2012-01-22 14:20 ` Jan Engelhardt
2012-01-22 14:26 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Jan Engelhardt @ 2012-01-22 14:20 UTC (permalink / raw)
To: Richard Weinberger; +Cc: netfilter-devel, netdev
On Sunday 2012-01-22 13:54, Richard Weinberger wrote:
>Hi!
>
>Is there no space after prefix for specific reason?
>ipt_log_packet() is using this format string:
>"<%d>%sIN=%s OUT=%s "
>
>Using a prefix leads to a broken log entry like this one (prefix is "foo"):
>"fooIN=eth0 OUT= ..."
>I'm sure this breaks log analyzers.
Changing it now will break log analyzers as well. So you are better off
leaving it as-is, because everybody who has observed that before you
already knows about it.
(Also consider --log-prefix "", in which case I would not want to have
a space.)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-22 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-22 12:54 ipt_LOG: No space after prefix Richard Weinberger
2012-01-22 14:20 ` Jan Engelhardt
2012-01-22 14:26 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).