From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Khemka Subject: Re: [PATCH v2] net/ncsi: Add NCSI OEM command support Date: Tue, 2 Oct 2018 21:34:57 +0000 Message-ID: <4F2DCF80-A0D8-4475-9777-72CFCA037BEC@fb.com> References: <20180929010602.1025909-1-vijaykhemka@fb.com> <1004987ef0ab138e772ed5740a0d839bffe39910.camel@mendozajonas.com> <4876838166d140bab331280efcfd771d@AUSX13MPS306.AMER.DELL.COM> <3dc1e3c74a864c3da7aaf19c3ca9edfa@AUSX13MPS306.AMER.DELL.COM> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 To: "Justin.Lee1@Dell.com" , "sam@mendozajonas.com" , "joel@jms.id.au" , "linux-aspeed@lists.ozlabs.org" , "openbmc@lists.ozlabs.org" , Sai Dasari , "netdev@vger.kernel.org" , "christian@cmd.nu" Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:54810 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726862AbeJCE20 (ORCPT ); Wed, 3 Oct 2018 00:28:26 -0400 In-Reply-To: <3dc1e3c74a864c3da7aaf19c3ca9edfa@AUSX13MPS306.AMER.DELL.COM> Content-Language: en-US Content-ID: <588F0335EA04074BA45B0A2D8841BCD0@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: SGkgSnVzdGluLA0KUGxlYXNlIHNlZSBjb21tZW50cyBiZWxvdw0KDQotVmlqYXkNCiANCiAgICA+ ID4gPiBkaWZmIC0tZ2l0IGEvbmV0L25jc2kvbmNzaS1jbWQuYyBiL25ldC9uY3NpL25jc2ktY21k LmMNCiAgICA+ID4gPiBpbmRleCA3NTY3Y2E2M2FhZTIuLjJmOTg1MzNlYmE0NiAxMDA2NDQNCiAg ICA+ID4gPiAtLS0gYS9uZXQvbmNzaS9uY3NpLWNtZC5jDQogICAgPiA+ID4gKysrIGIvbmV0L25j c2kvbmNzaS1jbWQuYw0KICAgID4gPiA+IEBAIC0yMTEsNiArMjExLDI2IEBAIHN0YXRpYyBpbnQg bmNzaV9jbWRfaGFuZGxlcl9zbmZjKHN0cnVjdCBza19idWZmICpza2IsDQogICAgPiA+ID4gIAly ZXR1cm4gMDsNCiAgICA+ID4gPiAgfQ0KICAgID4gPiA+ICANCiAgICA+ID4gPiArc3RhdGljIGlu dCBuY3NpX2NtZF9oYW5kbGVyX29lbShzdHJ1Y3Qgc2tfYnVmZiAqc2tiLA0KICAgID4gPiA+ICsJ CQkJc3RydWN0IG5jc2lfY21kX2FyZyAqbmNhKQ0KICAgID4gPiA+ICt7DQogICAgPiA+ID4gKwlz dHJ1Y3QgbmNzaV9jbWRfb2VtX3BrdCAqY21kOw0KICAgID4gDQogICAgPiA+T0VNIGNvbW1hbmQg ZG9lc24ndCBub3QgaGF2ZSB0aGUgZml4ZWQgZGF0YSBzaXplLiBTaG91bGQgd2UgdXNlIHBvaW50 ZXIgaW5zdGVhZD8NCiAgICA+ID5zdHJ1Y3QgbmNzaV9jbWRfb2VtX3BrdCB7DQogICAgPiA+CXN0 cnVjdCBuY3NpX2NtZF9wa3RfaGRyIGNtZDsgICAgICAgICAvKiBDb21tYW5kIGhlYWRlciAgICAq Lw0KICAgID4gPglfX2JlMzIgICAgICAgICAgICAgICAgICBtZnJfaWQ7ICAgICAgLyogTWFudWZh Y3R1cmUgSUQgICAgKi8NCiAgICA+ID4JdW5zaWduZWQgY2hhciAgICAgICAgICAgKmRhdGE7ICAg ICAgIC8qIE9FTSBQYXlsb2FkIERhdGEgICovDQogICAgPiA+fTsNCiAgICA+IFllcywgSSBhZ3Jl ZSB0aGF0IE9FTSBjb21tYW5kIGRvZXNuJ3QgaGF2ZSBmaXhlZCBkYXRhIGJ1dCB0byBtYXAgdG8g c2tidWZmIHN0cnVjdHVyZSwgDQogICAgPiBJIGhhdmUgZGVmaW5lZCBhYm92ZSBzdHJ1Y3R1cmUg YXMgcGVyIE5DU0kgc3BlYywgV2UgY2FuIGNlcnRhaW5seSBoYXZlIGEgTUFYX0RBVEFfTEVOIGRl ZmluZS4NCiAgICANCiAgICBUaGUgc3BlYyBvbmx5IGRlZmluZXMgbWFudWZhY3R1cmUgSUQgZmll bGQgYW5kIHRoZSBzdGFydCBvZmZzZXQgb2YgdmVuZG9yIGRhdGEuIA0KICAgIElmIHdlIGp1c3Qg d2FudCB0byBwb2ludCB0byB0aGUgdmVuZG9yIGRhdGEsIHdlIGRvbid0IG5lZWQgdG8gc3BlY2lm eSB0aGUgbWF4IGxlbmd0aCBhbmQNCiAgICB3ZSBjYW4gdXNlIGZsZXhpYmxlIGFycmF5IGFzIHRo ZSBsYXN0IG1lbWJlciAoY29ycmVjdCB0aGUgdHlwbyBhYm92ZSkuDQogICAgDQogICAgc3RydWN0 IG5jc2lfY21kX29lbV9wa3Qgew0KICAgIAlzdHJ1Y3QgbmNzaV9jbWRfcGt0X2hkciBjbWQ7ICAg ICAgICAgLyogQ29tbWFuZCBoZWFkZXIgICAgKi8NCiAgICAJX19iZTMyICAgICAgICAgICAgICAg ICAgbWZyX2lkOyAgICAgIC8qIE1hbnVmYWN0dXJlIElEICAgICovDQogICAgCXVuc2lnbmVkIGNo YXIgICAgICAgICAgIGRhdGFbXTsgICAgICAgLyogT0VNIFBheWxvYWQgRGF0YSAgKi8NCiAgICB9 Ow0KDQpJIGFncmVlIGFuZCB3aWxsIGFkZCB0aGlzIGNoYW5nZS4NCiAgICAgDQogICAgPiA+ID4g Kwl1bnNpZ25lZCBpbnQgbGVuOw0KICAgID4gPiA+ICsNCiAgICA+ID4gPiArCWxlbiA9IHNpemVv ZihzdHJ1Y3QgbmNzaV9jbWRfcGt0X2hkcikgKyA0Ow0KICAgID4gPiA+ICsJaWYgKG5jYS0+cGF5 bG9hZCA8IDI2KQ0KICAgID4gPiA+ICsJCWxlbiArPSAyNjsNCiAgICA+IA0KICAgID4gPldoeSBk b2VzIGl0IGFkZCAyNj8gSSBrbmV3IHRoZSBvdGhlciBwbGFjZSBpbiBuY3NpX2FsbG9jX2NvbW1h bmQoKSBpcyBhbHNvIGFkZCAyNi4NCiAgICA+ID5JZiBpdCBpcyBsZXNzIHRoYW4gMjYsIHRoZW4g aXQgc2hvdWxkIGJlIGEgZml4ZWQgc2l6ZSBvZiBzdHJ1Y3R1cmUgbmNzaV9jbWRfcGt0ICg0Niks IHJpZ2h0Pw0KICAgID4gSXQgYWRkcyAyNiBiZWNhdXNlIEl0IGhhcyBhbHJlYWR5IGFzc2lnbmVk IGxlbiB0byBoZHIrNCB3aGljaCBpcyAxNis0ID0gMjAgYnl0ZXMuIEJ5IA0KICAgID4gYWRkaW5n IDI2IGl0IG1ha2VzIGl0IHRvIDQ2LiBJIGFtIGp1c3QgYmVpbmcgY29uc2lzdGVudCB3aXRoIG90 aGVyIHBvcnRpb24gb2YgY29kZS4NCiAgICA+IA0KICAgID4gPiA+ICsJZWxzZQ0KICAgID4gPiA+ ICsJCWxlbiArPSBuY2EtPnBheWxvYWQ7DQogICAgPiA+ID4gKw0KICAgID4gPiA+ICsJY21kID0g c2tiX3B1dF96ZXJvKHNrYiwgbGVuKTsNCiAgICA+ID4gPiArCWNtZC0+bWZyX2lkID0gbmNhLT5k d29yZHNbMF07DQogICAgPiA+ID4gKwltZW1jcHkoY21kLT5kYXRhLCAmbmNhLT5kd29yZHNbMV0s IG5jYS0+cGF5bG9hZCAtIDQpOw0KICAgID4gDQogICAgPiA+TmV0bGluayByZXF1ZXN0IGlzIHVz aW5nIHRoZSBuZXcgbmNhLT5kYXRhIHBvaW50ZXIgdG8gcGFzcyB0aGUgZGF0YSBhcyB0aGUgcmVx dWVzdCBwYXlsb2FkDQogICAgPiA+aXMgbm90IHRoZSBzYW1lIHNpemUgYW5kIHNvbWUgY29tbWFu ZCBwYXlsb2FkIGlzIGJpZ2dlciB0aGFuIDE2IGJ5dGVzLg0KICAgID4gPldpbGwgeW91IGNvbnNp ZGVyIHRvIHVzZSB0aGUgc2FtZSBkYXRhIHBvaW50ZXI/IFNvLCB3ZSBkb24ndCBuZWVkIHRvIGhh dmUgYSBjaGVja2luZyBoZXJlLg0KICAgID4gPklmIHRoZSBjb21tYW5kIGlzIHVzZWQgbGVzcyB0 aGFuIDE2IGJ5dGVzLCB3ZSBjYW4gc2ltcGx5IGFzc2lnbmVkICZuY2EtPmJ5dGVzWzBdIHRvIGl0 Lg0KICAgID4gVG8ga2VlcCBvcmlnaW5hbCBzdHJ1Y3R1cmUsIHdlIGNhbiBjaGFuZ2UgMTYgYnl0 ZXMgdG8gTUFYX0RBVEFfTEVOLiBPciBJIGRvbid0IHNlZSBhbnkgaXNzdWUgaW4gDQogICAgPiBD b3B5aW5nIGRhdGEgZnJvbSBkYXRhIHBvaW50ZXIgZnJvbSBuY2EgYnV0IHVzZXIgbmVlZHMgdG8g YmUgYXdhcmUgaWYgaXQgaXMgbGVzcyB0aGFuIDE2IGJ5dGVzIHRoZW4gDQogICAgPiB1c2UgYnl0 ZXMgb3IgdXNlIGRhdGEgcG9pbnRlci4gVG8ga2VlcCBpdCBzaW1wbGUsIHdlIHNob3VsZCBzaW1w bHkgZGVmaW5lIE1BWF9MRU4uDQogICAgDQogICAgSSB1c2UgdGhlIHBvaW50ZXIgdG8gYXZvaWQg Y29weWluZyB0aGUgZGF0YSBhZ2Fpbi4gT0VNIGhhbmRsZXIgY2FuIGFsd2F5cyBwcm9jZXNzIHRo ZSBmbGV4aWJsZSBwYXlsb2FkDQogICAgdGhyb3VnaCB0aGUgZGF0YSBwb2ludGVyLiBJdCBjYW4g ZGVwZW5kIG9uIHRoZSBjYWxsZXIgdG8gdXNlIHN0YWNrL2FsbG9jYXRlZCBidWZmZXIvbmNhIGJ1 ZmZlciBhbmQNCiAgICBpdCB3aWxsIGJlIHN0cmFpZ2h0IGZvcndhcmQgaWYgYWxsIE9FTSBzdHVm ZiBpcyB1c2luZyB0aGUgZGF0YSBwb2ludGVyIHRvIHByb2Nlc3MgdGhlIGZsZXhpYmxlDQogICAg cGF5bG9hZC4NCg0KRG8gd2UgdXNlIGRhdGEgcG9pbnRlciBmb3IgcGF5bG9hZCBsZXNzIHRoYW4g MTYgYnl0ZXMgYXMgd2VsbCBpbiBPRU0uIFdlIGNvcHkgZGF0YSBvbmx5IG9uY2Ugd2hpbGUgYWRk aW5nIHRvIHNrYnVmZi4gDQpJIGhhdmUgbm8gaXNzdWUsIEkgd2lsbCBtYWtlIHRoaXMgY2hhbmdl IGJ1dCB3YWl0IGZvciBvdGhlciBjb21tZW50cy4NCiAgICANCiAgICA+IA0KICAgID4gPiA+IGRp ZmYgLS1naXQgYS9uZXQvbmNzaS9uY3NpLXBrdC5oIGIvbmV0L25jc2kvbmNzaS1wa3QuaA0KICAg ID4gPiA+IGluZGV4IDkxYjRiNjY0MzhkZi4uMWYzMzgzODY4MTBkIDEwMDY0NA0KICAgID4gPiA+ IC0tLSBhL25ldC9uY3NpL25jc2ktcGt0LmgNCiAgICA+ID4gPiArKysgYi9uZXQvbmNzaS9uY3Np LXBrdC5oDQogICAgPiA+ID4gQEAgLTE1MSw2ICsxNTEsMjIgQEAgc3RydWN0IG5jc2lfY21kX3Nu ZmNfcGt0IHsNCiAgICA+ID4gPiAgCXVuc2lnbmVkIGNoYXIgICAgICAgICAgIHBhZFsyMl07DQog ICAgPiA+ID4gIH07DQogICAgPiA+ID4gIA0KICAgID4gPiA+ICsvKiBPRU0gUmVxdWVzdCBDb21t YW5kIGFzIHBlciBOQ1NJIFNwZWNpZmljYXRpb24gKi8NCiAgICA+ID4gPiArc3RydWN0IG5jc2lf Y21kX29lbV9wa3Qgew0KICAgID4gPiA+ICsJc3RydWN0IG5jc2lfY21kX3BrdF9oZHIgY21kOyAg ICAgICAgIC8qIENvbW1hbmQgaGVhZGVyICAgICovDQogICAgPiA+ID4gKwlfX2JlMzIgICAgICAg ICAgICAgICAgICBtZnJfaWQ7ICAgICAgLyogTWFudWZhY3R1cmUgSUQgICAgKi8NCiAgICA+ID4g PiArCXVuc2lnbmVkIGNoYXIgICAgICAgICAgIGRhdGFbNjRdOyAgICAvKiBPRU0gUGF5bG9hZCBE YXRhICAqLw0KICAgID4gPiA+ICsJX19iZTMyICAgICAgICAgICAgICAgICAgY2hlY2tzdW07ICAg IC8qIENoZWNrc3VtICAgICAgICAgICovDQogICAgPiA+ID4gK307DQogICAgPiA+ID4gKw0KICAg ID4gPiA+ICsvKiBPRU0gUmVzcG9uc2UgUGFja2V0IGFzIHBlciBOQ1NJIFNwZWNpZmljYXRpb24g Ki8NCiAgICA+ID4gPiArc3RydWN0IG5jc2lfcnNwX29lbV9wa3Qgew0KICAgID4gPiA+ICsJc3Ry dWN0IG5jc2lfcnNwX3BrdF9oZHIgcnNwOyAgICAgICAgIC8qIENvbW1hbmQgaGVhZGVyICAgICov DQogICAgPiA+ID4gKwlfX2JlMzIgICAgICAgICAgICAgICAgICBtZnJfaWQ7ICAgICAgLyogTWFu dWZhY3R1cmUgSUQgICAgKi8NCiAgICA+ID4gPiArCXVuc2lnbmVkIGNoYXIgICAgICAgICAgIGRh dGFbNjRdOyAgICAvKiBQYXlsb2FkIGRhdGEgICAgICAqLw0KICAgID4gPiA+ICsJX19iZTMyICAg ICAgICAgICAgICAgICAgY2hlY2tzdW07ICAgIC8qIENoZWNrc3VtICAgICAgICAgICovDQogICAg PiA+ID4gK307DQogICAgPiA+ID4gKw0KICAgID4gDQogICAgPiA+T0VNIGNvbW1hbmQgZG9lc24n dCBub3QgaGF2ZSB0aGUgZml4ZWQgcmVzcG9uc2UgZGF0YSBzaXplIHRvby4NCiAgICA+ID5TaG91 bGQgd2UgdXNlIHBvaW50ZXIgaW5zdGVhZD8NCiAgICA+IA0KICAgID4gSGVyZSBhbHNvIHdlIGNh biBkZWZpbmUgTUFYX0RBVEFfTEVOIGJlY2F1c2UgZGF0YSBwb2ludGVyIHdvbid0IG1hcCB0byBz a2IgZGlyZWN0bHkuDQogICAgDQogICAgU3VnZ2VzdCB0byBjaGFuZ2UgYXMgYmVsb3cgZHVlIHRv IHRoZSBmbGV4aWJsZSByZXNwb25zZS4NCiAgICBzdHJ1Y3QgbmNzaV9yc3Bfb2VtX3BrdCB7DQog ICAgCXN0cnVjdCBuY3NpX3JzcF9wa3RfaGRyIHJzcDsgICAgICAgICAvKiBDb21tYW5kIGhlYWRl ciAgICAqLw0KICAgIAlfX2JlMzIgICAgICAgICAgICAgICAgICBtZnJfaWQ7ICAgICAgLyogTWFu dWZhY3R1cmUgSUQgICAgKi8NCiAgICAJdW5zaWduZWQgY2hhciAgICAgICAgICAgZGF0YVtdOyAg ICAvKiBQYXlsb2FkIGRhdGEgICAgICAqLw0KICAgIH07DQogICAgDQpTdXJlIGRvbmUuDQoNCg==