From: Ben Greear <greearb@candelatech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: jeffrey.t.kirsher@intel.com, Jeff Kirsher <tarbal@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 00/10] Low-level Ethernet debugging features.
Date: Fri, 10 Feb 2012 09:18:59 -0800 [thread overview]
Message-ID: <4F355183.2060704@candelatech.com> (raw)
In-Reply-To: <1328880345.2443.17.camel@edumazet-laptop>
On 02/10/2012 05:25 AM, Eric Dumazet wrote:
> Le jeudi 09 février 2012 à 21:42 -0800, Ben Greear a écrit :
>> On 02/09/2012 08:31 PM, Jeff Kirsher wrote:
>>
>>> Thanks Ben!
>>>
>>> I have applied the series of 10 patches to my queue. I would like to
>>> have our validation team validate the e100, e1000 and e1000e patches
>>> (and in-directly the net patches).
>>
>> Just in case you can generate errored frames other than ones with just
>> bad FCS, I'm curious to know if rx-all logic works with them.
>>
>> I was thinking I might could get at least some NICs to generate Runt frames
>> by sending small pkts and disabling frame padding, but haven't looked into
>> it too hard yet.
>
> I am interested by this, do you know some NICs able to disable frame
> padding ?
It looks like e1000e driver can send frames at down to 32 bytes, which
should be considered a runt. I think we'd just need to disable any
padding in the software stacks (not sure it's there now or not), and then
twiddle the 'PSP' but in the "Transmit Control Register".
I'm not sure the best way to enable this feature up at user-space level,
but we could piggy-back on the no-fcs socket option and extend that
flag to mean don't pad packets as well.
Or, could add a new sock-opt perhaps.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-02-10 17:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 19:54 [PATCH v2 00/10] Low-level Ethernet debugging features greearb
2012-02-08 19:54 ` [PATCH v2 01/10] net: Support RXFCS feature flag greearb
2012-02-08 19:54 ` [PATCH v2 02/10] e100: " greearb
2012-02-10 22:56 ` Michał Mirosław
2012-02-11 0:17 ` Ben Greear
2012-02-08 19:54 ` [PATCH v2 03/10] e1000e: " greearb
2012-02-10 22:46 ` Michał Mirosław
2012-02-10 22:57 ` Ben Greear
2012-02-10 23:09 ` Michał Mirosław
2012-02-11 0:06 ` Ben Greear
2012-02-08 19:54 ` [PATCH v2 04/10] net: Add framework to allow sending packets with customized CRC greearb
2012-02-08 19:54 ` [PATCH v2 05/10] e100: Support sending custom Ethernet CRC greearb
2012-02-08 19:54 ` [PATCH v2 06/10] e1000e: " greearb
2012-02-08 19:54 ` [PATCH v2 07/10] net: Support RX-ALL feature flag greearb
2012-02-08 19:54 ` [PATCH v2 08/10] e1000e: Support RXALL " greearb
2012-02-08 19:54 ` [PATCH v2 09/10] e100: " greearb
2012-02-08 19:54 ` [PATCH v2 10/10] e1000: Support sending custom Ethernet CRC greearb
2012-02-10 4:31 ` [PATCH v2 00/10] Low-level Ethernet debugging features Jeff Kirsher
2012-02-10 5:42 ` Ben Greear
2012-02-10 5:52 ` Jeff Kirsher
2012-02-10 13:25 ` Eric Dumazet
2012-02-10 13:45 ` David Laight
2012-02-10 13:51 ` Eric Dumazet
2012-02-10 14:09 ` Eric Dumazet
2012-02-10 17:18 ` Ben Greear [this message]
2012-02-10 20:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F355183.2060704@candelatech.com \
--to=greearb@candelatech.com \
--cc=eric.dumazet@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tarbal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).