From: Ben Greear <greearb@candelatech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.
Date: Mon, 13 Feb 2012 09:19:33 -0800 [thread overview]
Message-ID: <4F394625.9010702@candelatech.com> (raw)
In-Reply-To: <1328980060.5661.36.camel@edumazet-laptop>
On 02/11/2012 09:07 AM, Eric Dumazet wrote:
> Le vendredi 10 février 2012 à 17:04 -0800, greearb@candelatech.com a
> écrit :
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This allows e100 to be configured to append the
>> Ethernet FCS to the skb.
>>
>> Useful for sniffing networks.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>> ---
>
> Did you try this patch with 8021Q frames ?
>
> You must change
>
> #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN)
>
> to :
>
> #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN + ETH_FCS_LEN)
>
> And also on various spots where VLAN_ETH_FRAME_LEN is used in this
> driver...
>
> nic->blank_rfd.size = cpu_to_le16(VLAN_ETH_FRAME_LEN);
Thanks for the review. I did not try it with VLAN frames. It may
be a few days until I can get this done and test it well....
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-02-13 17:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 1:04 [PATCH v3 00/16] Low-level Ethernet debugging features greearb
2012-02-11 1:04 ` [PATCH v3 01/16] net: Support RXFCS feature flag greearb
2012-02-11 1:04 ` [PATCH v3 02/16] e100: " greearb
2012-02-11 16:07 ` Michał Mirosław
2012-02-11 16:21 ` Ben Greear
2012-02-11 17:07 ` Eric Dumazet
2012-02-13 17:19 ` Ben Greear [this message]
2012-02-11 1:04 ` [PATCH v3 03/16] e1000e: " greearb
2012-02-11 1:04 ` [PATCH v3 04/16] net: Add framework to allow sending packets with customized CRC greearb
2012-02-11 1:04 ` [PATCH v3 05/16] e100: Support sending custom Ethernet CRC greearb
2012-02-11 1:04 ` [PATCH v3 06/16] e1000e: " greearb
2012-02-11 1:04 ` [PATCH v3 07/16] net: Support RX-ALL feature flag greearb
2012-02-11 1:04 ` [PATCH v3 08/16] e1000e: Support RXALL " greearb
2012-02-11 1:04 ` [PATCH v3 09/16] e100: " greearb
2012-02-11 1:04 ` [PATCH v3 10/16] e1000: Support sending custom Ethernet CRC greearb
2012-02-11 1:04 ` [PATCH v3 11/16] e1000: Support RX-ALL flag greearb
2012-02-11 1:04 ` [PATCH v3 12/16] e1000: Support RX-FCS flag greearb
2012-02-11 1:04 ` [PATCH v3 13/16] 8139too: Support RX-ALL logic greearb
2012-02-11 1:04 ` [PATCH v3 14/16] 8139too: Support RX-FCS flag greearb
2012-02-11 1:04 ` [PATCH v3 15/16] r8169: Support RX-ALL flag greearb
2012-02-11 1:04 ` [PATCH v3 16/16] r8169: Support RX-FCS flag greearb
2012-02-11 7:56 ` [PATCH v3 00/16] Low-level Ethernet debugging features Jeff Kirsher
2012-02-11 10:51 ` Francois Romieu
2012-02-11 16:20 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F394625.9010702@candelatech.com \
--to=greearb@candelatech.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).