From: John Fastabend <john.r.fastabend@intel.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Shradha Shah <sshah@solarflare.com>,
Patrick McHardy <kaber@trash.net>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH net] macvlan: Disable LRO on lowerdev; warn if it's turned back on
Date: Tue, 21 Feb 2012 12:01:26 -0800 [thread overview]
Message-ID: <4F43F816.6070908@intel.com> (raw)
In-Reply-To: <1329851622.2689.6.camel@bwh-desktop>
On 2/21/2012 11:13 AM, Ben Hutchings wrote:
> Large Receive Offload (LRO) is only appropriate for packets that are
> destined for the host, and should be disabled if received packets may
> be forwarded.
>
> Further, macvtap_skb_to_vnet_hdr() will BUG() on a packet received
> with LRO (but not GRO).
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> I'm not really familiar with macvlan so I'm not certain that this should
> be applied to all modes.
>
> Ben.
>
> drivers/net/macvlan.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
But this patch assumes the macvlan is forwarding traffic to a guest
via macvtap. Which is an assumption that may not be true.
It seems more appropriate for the macvtap driver to do these checks
after all its the driver that may BUG() with LRO.
Thanks,
John
next prev parent reply other threads:[~2012-02-21 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 19:13 [PATCH net] macvlan: Disable LRO on lowerdev; warn if it's turned back on Ben Hutchings
2012-02-21 20:01 ` John Fastabend [this message]
2012-02-21 20:28 ` Ben Hutchings
2012-02-21 21:46 ` Ben Greear
2012-02-25 22:07 ` Eric W. Biederman
2012-02-25 22:49 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F43F816.6070908@intel.com \
--to=john.r.fastabend@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).