From: "Niccolò Belli" <darkbasic@linuxsystems.it>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Linux Networking Developer Mailing List <netdev@vger.kernel.org>,
openadsl-users@lists.sourceforge.net,
openadsl-devel@lists.sourceforge.net, 660804@bugs.debian.org,
support@traverse.com.au, support@rocksolidelectronics.com
Subject: Re: [Bug 42809] New: kernel panic when receiving an ipsec packet
Date: Thu, 23 Feb 2012 14:45:49 +0100 [thread overview]
Message-ID: <4F46430D.3060802@linuxsystems.it> (raw)
In-Reply-To: <1329962785.15610.8.camel@edumazet-laptop>
Il 23/02/2012 03:06, Eric Dumazet ha scritto:
> Thanks !
>
> Please try following patch.
>
> diff --git a/net/ipv4/xfrm4_mode_tunnel.c b/net/ipv4/xfrm4_mode_tunnel.c
> index 534972e..f170933 100644
> --- a/net/ipv4/xfrm4_mode_tunnel.c
> +++ b/net/ipv4/xfrm4_mode_tunnel.c
> @@ -84,9 +84,11 @@ static int xfrm4_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
> if (!(x->props.flags& XFRM_STATE_NOECN))
> ipip_ecn_decapsulate(skb);
>
> - old_mac = skb_mac_header(skb);
> - skb_set_mac_header(skb, -skb->mac_len);
> - memmove(skb_mac_header(skb), old_mac, skb->mac_len);
> + if (skb_mac_header_was_set(skb)) {
> + old_mac = skb_mac_header(skb);
> + skb_set_mac_header(skb, -skb->mac_len);
> + memmove(skb_mac_header(skb), old_mac, skb->mac_len);
> + }
> skb_reset_network_header(skb);
> err = 0;
>
Your patch does solve the problem, thanks!
Niccolò
next prev parent reply other threads:[~2012-02-23 13:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-42809-100@https.bugzilla.kernel.org/>
2012-02-22 17:20 ` [Bug 42809] New: kernel panic when receiving an ipsec packet Stephen Hemminger
2012-02-22 17:41 ` Niccolò Belli
2012-02-23 0:59 ` Niccolò Belli
2012-02-23 1:38 ` Eric Dumazet
2012-02-23 1:46 ` [openadsl-users] " Jason White
2012-02-23 1:54 ` Eric Dumazet
2012-02-23 13:48 ` Bug#660804: " chas williams - CONTRACTOR
2012-02-23 1:55 ` Niccolò Belli
2012-02-23 2:02 ` Niccolò Belli
2012-02-23 2:06 ` Eric Dumazet
2012-02-23 2:12 ` Niccolò Belli
2012-02-23 13:45 ` Niccolò Belli [this message]
2012-02-23 14:36 ` Eric Dumazet
2012-02-23 14:39 ` Eric Dumazet
2012-02-23 19:08 ` Niccolò Belli
2012-02-23 20:11 ` David Miller
2012-02-23 20:17 ` Eric Dumazet
2012-02-23 20:23 ` David Miller
2012-02-23 20:28 ` Eric Dumazet
2012-02-23 20:55 ` [PATCH V2] ipsec: be careful of non existing mac headers Eric Dumazet
2012-02-23 21:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F46430D.3060802@linuxsystems.it \
--to=darkbasic@linuxsystems.it \
--cc=660804@bugs.debian.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openadsl-devel@lists.sourceforge.net \
--cc=openadsl-users@lists.sourceforge.net \
--cc=support@rocksolidelectronics.com \
--cc=support@traverse.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).