From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gao feng <gaofeng@cn.fujitsu.com>
Subject: Re: [PATCH] ipv6: Fix problem with expired dst cache
Date: Fri, 24 Feb 2012 15:21:50 +0800
Message-ID: <4F473A8E.9080402@cn.fujitsu.com>
References: <1330064404-24763-1-git-send-email-gaofeng@cn.fujitsu.com> <1330066268.15610.48.camel@edumazet-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: davem@davemloft.net, netdev@vger.kernel.org
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:49988 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1754258Ab2BXHU6 convert rfc822-to-8bit (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 24 Feb 2012 02:20:58 -0500
In-Reply-To: <1330066268.15610.48.camel@edumazet-laptop>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

=E4=BA=8E 2012=E5=B9=B402=E6=9C=8824=E6=97=A5 14:51, Eric Dumazet =E5=86=
=99=E9=81=93:
> Le vendredi 24 f=C3=A9vrier 2012 =C3=A0 14:20 +0800, Gao feng a =C3=A9=
crit :
>> if the ipv6 dst cache copy from the dst witch generated by ICMPV6 RA=
 packet.
>> this dst cache will not be checked expire because it has no RTF_EXPI=
RES flag
>> So this dst cache always be used until the dst gc run.
>>
>> add a pointer in struct rt6_info,point to where the dst cache copy f=
rom.
>> in func rt6_check_expired check if rt6->info->rt6i_copy is expired.
>>
>=20
> Sorry, I really dont understand what you are saying.

Just because ipv6 dst cache has no RTF_EXPIRES flag,
so even this dst cache has expired,it will be used until the gc run.

>=20
> Also, adding a pointer to a structure without holding a reference on =
it
> is suspicious.
>=20

OK,I think there is no use to hold a reference.
the dst cache will be deleted before the pointer,
So this pointer will be always usefull.