From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH V2 11/14] NET: MIPS: lantiq: convert etop driver to clkdev api
Date: Fri, 24 Feb 2012 14:55:15 +0400 [thread overview]
Message-ID: <4F476C93.2000304@mvista.com> (raw)
In-Reply-To: <1330012993-13510-11-git-send-email-blogic@openwrt.org>
Hello.
On 23-02-2012 20:03, John Crispin wrote:
> Update from old pmu_{dis,en}able() to ckldev api.
> Signed-off-by: John Crispin<blogic@openwrt.org>
> Cc: netdev@vger.kernel.org
[...]
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index e5ec8b1..6b2e4b4 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
[...]
> @@ -886,6 +903,22 @@ ltq_etop_probe(struct platform_device *pdev)
> priv->pdev = pdev;
> priv->pldata = dev_get_platdata(&pdev->dev);
> priv->netdev = dev;
> +
> + priv->clk_ppe = clk_get(&pdev->dev, NULL);
> + if (!priv->clk_ppe)
> + return -ENOENT;
> + if (ltq_has_gbit()) {
> + priv->clk_switch = clk_get(&pdev->dev, "switch");
> + if (!priv->clk_switch)
clk_get() doesn't retirn NULL, it returns error code.
> + return -ENOENT;
> + }
> + if (ltq_is_ase()) {
> + priv->clk_ephy = clk_get(&pdev->dev, "ephy");
> + priv->clk_ephycgu = clk_get(&pdev->dev, "ephycgu");
> + if (!priv->clk_ephy || !priv->clk_ephycgu)
Same here.
WBR, Sergei
prev parent reply other threads:[~2012-02-24 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1330012993-13510-1-git-send-email-blogic@openwrt.org>
2012-02-23 16:03 ` [PATCH V2 11/14] NET: MIPS: lantiq: convert etop driver to clkdev api John Crispin
2012-02-24 8:28 ` David Miller
2012-02-24 8:40 ` John Crispin
2012-02-24 8:53 ` David Miller
2012-02-24 10:55 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F476C93.2000304@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).