netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] of/mdio: fix fixed link bus name
@ 2012-02-27 12:48 Baruch Siach
  2012-02-27 14:46 ` Florian Fainelli
  2012-02-27 15:59 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2012-02-27 12:48 UTC (permalink / raw)
  To: Grant Likely, Rob Herring
  Cc: devicetree-discuss, netdev, linuxppc-dev, Baruch Siach

Since 9e6c643b (phy/fixed: use an unique MDIO bus name) the name of the fixed
PHY bus is "fixed-0". Teach of_phy_connect_fixed_link() the new name.

Tested on a P1020RDB PowerPC system.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/of/of_mdio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 980c079..483c0ad 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -182,7 +182,7 @@ struct phy_device *of_phy_connect_fixed_link(struct net_device *dev,
 	if (!phy_id || sz < sizeof(*phy_id))
 		return NULL;
 
-	sprintf(bus_id, PHY_ID_FMT, "0", be32_to_cpu(phy_id[0]));
+	sprintf(bus_id, PHY_ID_FMT, "fixed-0", be32_to_cpu(phy_id[0]));
 
 	phy = phy_connect(dev, bus_id, hndlr, 0, iface);
 	return IS_ERR(phy) ? NULL : phy;
-- 
1.7.9

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] of/mdio: fix fixed link bus name
  2012-02-27 12:48 [PATCH] of/mdio: fix fixed link bus name Baruch Siach
@ 2012-02-27 14:46 ` Florian Fainelli
  2012-02-27 15:59 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2012-02-27 14:46 UTC (permalink / raw)
  To: Baruch Siach
  Cc: Grant Likely, Rob Herring, devicetree-discuss, netdev,
	linuxppc-dev



Le 02/27/12 13:48, Baruch Siach a écrit :
> Since 9e6c643b (phy/fixed: use an unique MDIO bus name) the name of the fixed
> PHY bus is "fixed-0". Teach of_phy_connect_fixed_link() the new name.
>
> Tested on a P1020RDB PowerPC system.
>
> Signed-off-by: Baruch Siach<baruch@tkos.co.il>

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>   drivers/of/of_mdio.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 980c079..483c0ad 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -182,7 +182,7 @@ struct phy_device *of_phy_connect_fixed_link(struct net_device *dev,
>   	if (!phy_id || sz<  sizeof(*phy_id))
>   		return NULL;
>
> -	sprintf(bus_id, PHY_ID_FMT, "0", be32_to_cpu(phy_id[0]));
> +	sprintf(bus_id, PHY_ID_FMT, "fixed-0", be32_to_cpu(phy_id[0]));
>
>   	phy = phy_connect(dev, bus_id, hndlr, 0, iface);
>   	return IS_ERR(phy) ? NULL : phy;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of/mdio: fix fixed link bus name
  2012-02-27 12:48 [PATCH] of/mdio: fix fixed link bus name Baruch Siach
  2012-02-27 14:46 ` Florian Fainelli
@ 2012-02-27 15:59 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2012-02-27 15:59 UTC (permalink / raw)
  To: Baruch Siach; +Cc: Grant Likely, netdev, devicetree-discuss, linuxppc-dev

On 02/27/2012 06:48 AM, Baruch Siach wrote:
> Since 9e6c643b (phy/fixed: use an unique MDIO bus name) the name of the fixed
> PHY bus is "fixed-0". Teach of_phy_connect_fixed_link() the new name.
> 

Applied for 3.3.

Rob

> Tested on a P1020RDB PowerPC system.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  drivers/of/of_mdio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 980c079..483c0ad 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -182,7 +182,7 @@ struct phy_device *of_phy_connect_fixed_link(struct net_device *dev,
>  	if (!phy_id || sz < sizeof(*phy_id))
>  		return NULL;
>  
> -	sprintf(bus_id, PHY_ID_FMT, "0", be32_to_cpu(phy_id[0]));
> +	sprintf(bus_id, PHY_ID_FMT, "fixed-0", be32_to_cpu(phy_id[0]));
>  
>  	phy = phy_connect(dev, bus_id, hndlr, 0, iface);
>  	return IS_ERR(phy) ? NULL : phy;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-27 15:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-27 12:48 [PATCH] of/mdio: fix fixed link bus name Baruch Siach
2012-02-27 14:46 ` Florian Fainelli
2012-02-27 15:59 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).