From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH v3 1/4] SUNRPC: release per-net clients lock before calling PipeFS dentries creation Date: Mon, 27 Feb 2012 22:07:14 +0400 Message-ID: <4F4BC652.6030300@parallels.com> References: <20120227180509.1089.29555.stgit@localhost6.localdomain6> <20120227180529.1089.29305.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "bfields@fieldses.org" , "davem@davemloft.net" , "devel@openvz.org" To: "Trond.Myklebust@netapp.com" Return-path: In-Reply-To: <20120227180529.1089.29305.stgit@localhost6.localdomain6> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org 27.02.2012 22:05, Stanislav Kinsbursky =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > v3: > 1) Lookup for client is performed from the beginning of the list on e= ach PipeFS > event handling operation. > > Lockdep is sad otherwise, because inode mutex is taken on PipeFS dent= ry > creation, which can be called on mount notification, where this per-n= et client > lock is taken on clients list walk. > > Signed-off-by: Stanislav Kinsbursky > > --- > net/sunrpc/clnt.c | 26 +++++++++++++++++++++----- > 1 files changed, 21 insertions(+), 5 deletions(-) > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index bb7ed2f3..48f3d15 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -50,7 +50,7 @@ > __func__, t->tk_status) > > /* > - * All RPC clients are linked into this list > + * All RPC clients are linked into this list Client Cto hand;le usta= tus is checke > */ > > static DECLARE_WAIT_QUEUE_HEAD(destroy_wait); Sorry for this hunk. --=20 Best regards, Stanislav Kinsbursky