netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: baruch@tkos.co.il
Cc: alexander.h.duyck@intel.com, ian.campbell@citrix.com,
	netdev@vger.kernel.org, eilong@broadcom.com,
	Kevin Wells <kevin.wells@nxp.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	jeffrey.t.kirsher@intel.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver
Date: Tue, 28 Feb 2012 14:08:40 +0100	[thread overview]
Message-ID: <4F4CD1D8.8030102@antcom.de> (raw)

Hi,

On 2012-02-26 03:28 +100, David Miller wrote:
>> Please use a module_param() instead of a top level kernel parameter.
>
> Actually, remove this entirely, we don't add module parameters
> to force the ethernet address. That should be done in userland
> in some fashion.
>
> We've had many discussions about this recently, and this is the
> consistent policy we want to enforce in all drivers from now on.

Thanks for the note! I actually found out that in many cases, the
bootloader already initialized the hardware with the target MAC address
so we can use this one.

For the case that it _isn't_ initialized already, is it the right thing
to use a hard coded default MAC address to be replaced by the final one
in userspace? (I found such examples in some current micrel/ and amd/
drivers.)

Thanks in advance,

Roland

             reply	other threads:[~2012-02-28 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 13:08 Roland Stigge [this message]
2012-02-28 13:11 ` [PATCH v2] ARM: LPC32xx: Ethernet driver David Laight
2012-02-28 13:32   ` Roland Stigge
2012-02-28 13:41     ` Arnd Bergmann
2012-02-28 13:49       ` Roland Stigge
2012-02-28 15:53       ` Ben Hutchings
2012-02-28 19:13 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2012-02-25 20:21 Roland Stigge
2012-02-25 20:41 ` Joe Perches
2012-02-26  1:52 ` Baruch Siach
2012-02-26  2:28   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4CD1D8.8030102@antcom.de \
    --to=stigge@antcom.de \
    --cc=alexander.h.duyck@intel.com \
    --cc=baruch@tkos.co.il \
    --cc=eilong@broadcom.com \
    --cc=ian.campbell@citrix.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=kevin.wells@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).