From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Deepak SIKRI <deepak.sikri@st.com>
Cc: spear-devel@list.st.com, netdev@vger.kernel.org
Subject: Re: [PATCH 0/6] stmmac: Driver Updates
Date: Mon, 05 Mar 2012 16:31:52 +0100 [thread overview]
Message-ID: <4F54DC68.4050708@st.com> (raw)
In-Reply-To: <1330692928-30330-1-git-send-email-deepak.sikri@st.com>
Hello Deepak
thanks for these patches.
I've just commented the patches #1 #2 #3.
I've found some problem when apply them in git.net.
I'll look at the patches #4 and #5 tomorrow and then I'll give you my
feedback. These have an impact on old driver versions too.
Patch #6, at first glance looks fine to me. I'll give you mu Acked-by as
soon as I complete the review.
Sorry for the delay
Regards
Peppe
On 3/2/2012 1:55 PM, Deepak SIKRI wrote:
> This patch set modifies the stmmac driver.
> Following changes have been done in the patch set.
> 1. Explicitly have the option to pass checksum offload engine type
> through the platform code. This is helpful for stmmac core prior to
> revision 3.5
> 2. Pass the default value of clk_csr scaling through the platform code.
> Define the scaling macros to be consistently used across driver and plat
> code.
> 3. Update the stmmac driver to incorporate the CPU freq framework.
> 4. Update the DMA descriptor status checks for cores prior to rev-3.5.
> 5. Configure burst related DMA parameter for cores revision beyond
> rev-3.6
> 6. Replace infinite loop in mdio read and write by timeouts
>
> Deepak Sikri (6):
> stmmac: Define CSUM offload engine Types
> stmmac: Define MDC clock selection macros.
> stmmac: Add support for CPU freq notifiers.
> stmmac: Update stmmac descriptor checks for stmmac core prior to
> Rev-3.5.
> stmmac: configure burst related GMAC DMA parameters
> stmmac: Replace infinite loops by timeouts in mdio r/w
>
> drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
> .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 14 ++-
> drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h | 1 +
> drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 17 ++-
> drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 10 ++
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 138 +++++++++++++++++++-
> drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 30 ++++-
> include/linux/stmmac.h | 36 +++++
> 9 files changed, 229 insertions(+), 21 deletions(-)
>
>
prev parent reply other threads:[~2012-03-05 15:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 12:55 [PATCH 0/6] stmmac: Driver Updates Deepak Sikri
2012-03-02 12:55 ` [PATCH 1/6] stmmac: Define CSUM offload engine Types Deepak Sikri
2012-03-02 12:55 ` [PATCH 2/6] stmmac: Define MDC clock selection macros Deepak Sikri
2012-03-02 12:55 ` [PATCH 3/6] stmmac: Add support for CPU freq notifiers Deepak Sikri
2012-03-02 12:55 ` [PATCH 4/6] stmmac: Update stmmac descriptor checks for stmmac core prior to Rev-3.5 Deepak Sikri
2012-03-02 12:55 ` [PATCH 5/6] stmmac: configure burst related GMAC DMA parameters Deepak Sikri
2012-03-02 12:55 ` [PATCH 6/6] stmmac: Replace infinite loops by timeouts in mdio r/w Deepak Sikri
2012-03-06 7:55 ` Giuseppe CAVALLARO
2012-03-05 1:52 ` [PATCH 5/6] stmmac: configure burst related GMAC DMA parameters David Miller
2012-03-07 5:39 ` deepaksi
2012-03-06 7:43 ` Giuseppe CAVALLARO
2012-03-07 6:18 ` deepaksi
2012-03-05 1:51 ` [PATCH 4/6] stmmac: Update stmmac descriptor checks for stmmac core prior to Rev-3.5 David Miller
2012-03-05 4:01 ` Shiraz Hashim
2012-03-05 4:59 ` David Miller
2012-03-07 8:26 ` deepaksi
2012-03-06 7:10 ` Giuseppe CAVALLARO
2012-03-07 8:25 ` deepaksi
2012-03-07 8:45 ` Giuseppe CAVALLARO
2012-03-05 1:50 ` [PATCH 3/6] stmmac: Add support for CPU freq notifiers David Miller
2012-03-07 7:18 ` deepaksi
2012-03-05 15:05 ` Giuseppe CAVALLARO
2012-03-06 8:04 ` Giuseppe CAVALLARO
2012-03-07 8:28 ` deepaksi
2012-03-07 7:17 ` deepaksi
2012-03-05 14:34 ` [PATCH 2/6] stmmac: Define MDC clock selection macros Giuseppe CAVALLARO
2012-03-07 6:55 ` deepaksi
2012-03-07 7:19 ` Giuseppe CAVALLARO
2012-03-07 8:30 ` deepaksi
2012-03-05 14:13 ` [PATCH 1/6] stmmac: Define CSUM offload engine Types Giuseppe CAVALLARO
2012-03-07 6:50 ` deepaksi
2012-03-05 15:31 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54DC68.4050708@st.com \
--to=peppe.cavallaro@st.com \
--cc=deepak.sikri@st.com \
--cc=netdev@vger.kernel.org \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).