From: John Fastabend <john.r.fastabend@intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: therbert@google.com, davem@davemloft.net, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: make CONFIG_BQL actually end user configurable
Date: Mon, 05 Mar 2012 20:11:26 -0800 [thread overview]
Message-ID: <4F558E6E.4000707@intel.com> (raw)
In-Reply-To: <1331005096-12332-1-git-send-email-paul.gortmaker@windriver.com>
On 3/5/2012 7:38 PM, Paul Gortmaker wrote:
> Without the defining string or help text, LKC won't ever bother
> to ask the end user for a setting for CONFIG_BQL -- you could
> delete it from your .config and run make oldconfig and not a
> thing would change -- it would still be silently re-enabled.
>
> While most people will have no reason to turn this off, the
> ability to do so can be useful for testing BQL support additions
> on previously BQL-unaware drivers and similar.
>
> The kconfig help text is largely taken from the original RFC
> patchset 0/N header sent to netdev@vger.kernel.org in fall 2011.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [Apologies if this was explicitly blocked for a reason; I couldn't
> find a reason after searching netdev or threads at bufferbloat.net ]
>
It was intentional "The Kconfig entry and option is merely for
expressing internal dependencies,". See the comments in the patch
http://patchwork.ozlabs.org/patch/128727/
And corresponding mail,
http://lists.openwall.net/netdev/2011/12/01/130
.John
next prev parent reply other threads:[~2012-03-06 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 3:38 [PATCH] net: make CONFIG_BQL actually end user configurable Paul Gortmaker
[not found] ` <CAA93jw5HadpvBvtZvf6ArK3tdm=7Cs9sLYeHO9WN6rJOfPLPbA@mail.gmail.com>
2012-03-06 4:09 ` Paul Gortmaker
2012-03-06 5:57 ` Tom Herbert
2012-03-06 4:11 ` David Miller
2012-03-06 4:11 ` John Fastabend [this message]
2012-03-06 4:17 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F558E6E.4000707@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).