From mboxrd@z Thu Jan  1 00:00:00 1970
From: Li Wei <lw@cn.fujitsu.com>
Subject: Re: IPv6: Fix not join all-router mcast group when forwarding set.
Date: Thu, 08 Mar 2012 09:02:59 +0800
Message-ID: <4F580543.7010405@cn.fujitsu.com>
References: <20120307114502.GA13204@elgon.mountain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:42163 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1752034Ab2CHBN3 (ORCPT <rfc822;netdev@vger.kernel.org>);
	Wed, 7 Mar 2012 20:13:29 -0500
In-Reply-To: <20120307114502.GA13204@elgon.mountain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Hello Li Wei,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch d6ddef9e641d: "IPv6: Fix not join all-router mcast group 
> when forwarding set." from Mar 5, 2012, leads to the following Smatch 
> complaint:
> 
> net/ipv6/addrconf.c:438 ipv6_add_dev()
> 	 warn: variable dereferenced before check 'dev' (see line 432)
> 
> net/ipv6/addrconf.c
>    431		/* protected by rtnl_lock */
>    432		rcu_assign_pointer(dev->ip6_ptr, ndev);
>                                    ^^^^^^^^^^^^
> Old dereference.
> 
>    433	
>    434		/* Join all-node multicast group */
>    435		ipv6_dev_mc_inc(dev, &in6addr_linklocal_allnodes);
>    436	
>    437		/* Join all-router multicast group if forwarding is set */
>    438		if (ndev->cnf.forwarding && dev && (dev->flags & IFF_MULTICAST))
>                                             ^^^
> 
> New check.  Probably you can just remove the check?
> 
>    439			ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
>    440	
> 
> regards,
> dan carpenter
> 
> 
> 

Hi Dan, 

Thanks for your report, I have sent a patch to fix this.

Regards,
Li Wei