From: Jarod Wilson <jarod@redhat.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: linux-kernel@vger.kernel.org, Paul Wouters <pwouters@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Martin Willi <martin@strongswan.org>,
netdev@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] xfrm: fix hmac(sha256) truncation length
Date: Fri, 09 Mar 2012 08:41:10 -0500 [thread overview]
Message-ID: <4F5A0876.3060408@redhat.com> (raw)
In-Reply-To: <20120308003741.GA14995@gondor.apana.org.au>
Herbert Xu wrote:
> On Wed, Mar 07, 2012 at 03:12:37PM -0500, Jarod Wilson wrote:
>> Commit bc74b0c8af17458ecae77f725e507ab5fd100105 added proper hmac sha384
>> and sha512 variants with truncation lengths of 192 and 256 respectively,
>> per RFC4868:
>
> No, it was done deliberately to maintain backwards compatibility.
> Userspace should set the truncbits explicitly from now on.
Okay, I suspected that might be the case. No plans to ever invert that,
so that userspace has to explicitly set the shorter truncbits for
backwards compat?
--
Jarod Wilson
jarod@redhat.com.
next prev parent reply other threads:[~2012-03-09 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 20:12 [PATCH] xfrm: fix hmac(sha256) truncation length Jarod Wilson
2012-03-08 0:37 ` Herbert Xu
2012-03-09 13:41 ` Jarod Wilson [this message]
2012-03-09 13:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A0876.3060408@redhat.com \
--to=jarod@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@strongswan.org \
--cc=netdev@vger.kernel.org \
--cc=pwouters@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).