netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] net: qmi_wwan: fix build error due to cdc-wdm dependecy
Date: Mon, 19 Mar 2012 13:16:55 -0700	[thread overview]
Message-ID: <4F679437.8030201@xenotime.net> (raw)
In-Reply-To: <1332179309-4163-1-git-send-email-bjorn@mork.no>

On 03/19/2012 10:48 AM, Bjørn Mork wrote:

> Fixes:
> 
> drivers/built-in.o: In function `qmi_wwan_bind_shared':
> qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>


Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.


> ---
> Thanks for noticing.
> 
> This should have been in commit c3ecb08a
>  net: qmi_wwan: support devices having a shared QMI/wwan interface
> 
> 
> Bjørn
> 
> 
>  drivers/net/usb/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 4bad899..833e32f 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -401,6 +401,7 @@ config USB_NET_KALMIA
>  config USB_NET_QMI_WWAN
>  	tristate "QMI WWAN driver for Qualcomm MSM based 3G and LTE modems"
>  	depends on USB_USBNET
> +	select USB_WDM
>  	help
>  	  Support WWAN LTE/3G devices based on Qualcomm Mobile Data Modem
>  	  (MDM) chipsets.  Examples of such devices are



-- 
~Randy

  reply	other threads:[~2012-03-19 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120319184830.fce597a16eaf7206195a7a45@canb.auug.org.au>
2012-03-19 15:15 ` linux-next: Tree for Mar 19 (net/usb) Randy Dunlap
2012-03-19 17:48 ` [PATCH] net: qmi_wwan: fix build error due to cdc-wdm dependecy Bjørn Mork
2012-03-19 20:16   ` Randy Dunlap [this message]
2012-03-19 22:17     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F679437.8030201@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).