From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: davej@redhat.com, netdev@vger.kernel.org
Subject: Re: Improve rds_sendmsg printk
Date: Tue, 20 Mar 2012 09:50:47 -0500 [thread overview]
Message-ID: <4F689947.30405@oracle.com> (raw)
In-Reply-To: <20120319.184335.1229962428916453634.davem@davemloft.net>
On 3/19/2012 5:43 PM, David Miller wrote:
> From: Dave Jones<davej@redhat.com>
> Date: Mon, 19 Mar 2012 18:40:09 -0400
>
>> - Given this can be called by any user, prevent them from flooding
>> the logs by using printk_ratelimited
>> - Also add a rds: prefix, so it's clear where the message is coming from.
>>
>> Signed-off-by: Dave Jones<davej@redhat.com>
> I think it should be removed entirely, no socket layer outputs
> a message for this error and neither should rds.
Agree, the message could be removed entirely.
Venkat
next prev parent reply other threads:[~2012-03-20 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 22:40 Improve rds_sendmsg printk Dave Jones
2012-03-19 22:43 ` David Miller
2012-03-19 23:01 ` Remove printk from rds_sendmsg Dave Jones
2012-03-20 20:12 ` David Miller
2012-03-20 14:50 ` Venkat Venkatsubra [this message]
2012-03-19 23:08 ` Improve rds_sendmsg printk Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F689947.30405@oracle.com \
--to=venkat.x.venkatsubra@oracle.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).