* [patch] RDS: use gfp flags from caller in conn_alloc()
@ 2012-03-22 6:44 Dan Carpenter
2012-03-22 15:19 ` Venkat Venkatsubra
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-03-22 6:44 UTC (permalink / raw)
To: Venkat Venkatsubra; +Cc: David S. Miller, rds-devel, netdev, kernel-janitors
We should be using the gfp flags the caller specified here, instead of
GFP_KERNEL. I think this might be a bugfix, depending on the value of
"sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in
rds_sendmsg(). Otherwise, it's just a cleanup.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/rds/loop.c b/net/rds/loop.c
index 87ff2a8..6b12b68 100644
--- a/net/rds/loop.c
+++ b/net/rds/loop.c
@@ -121,7 +121,7 @@ static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp)
struct rds_loop_connection *lc;
unsigned long flags;
- lc = kzalloc(sizeof(struct rds_loop_connection), GFP_KERNEL);
+ lc = kzalloc(sizeof(struct rds_loop_connection), gfp);
if (!lc)
return -ENOMEM;
diff --git a/net/rds/iw_cm.c b/net/rds/iw_cm.c
index 9556d28..a91e1db 100644
--- a/net/rds/iw_cm.c
+++ b/net/rds/iw_cm.c
@@ -694,7 +694,7 @@ int rds_iw_conn_alloc(struct rds_connection *conn, gfp_t gfp)
unsigned long flags;
/* XXX too lazy? */
- ic = kzalloc(sizeof(struct rds_iw_connection), GFP_KERNEL);
+ ic = kzalloc(sizeof(struct rds_iw_connection), gfp);
if (!ic)
return -ENOMEM;
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index 51c8689..a1e1162 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -749,7 +749,7 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp)
int ret;
/* XXX too lazy? */
- ic = kzalloc(sizeof(struct rds_ib_connection), GFP_KERNEL);
+ ic = kzalloc(sizeof(struct rds_ib_connection), gfp);
if (!ic)
return -ENOMEM;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] RDS: use gfp flags from caller in conn_alloc()
2012-03-22 6:44 [patch] RDS: use gfp flags from caller in conn_alloc() Dan Carpenter
@ 2012-03-22 15:19 ` Venkat Venkatsubra
2012-03-22 23:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Venkat Venkatsubra @ 2012-03-22 15:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David S. Miller, rds-devel, netdev, kernel-janitors
On 3/22/2012 1:44 AM, Dan Carpenter wrote:
> We should be using the gfp flags the caller specified here, instead of
> GFP_KERNEL. I think this might be a bugfix, depending on the value of
> "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in
> rds_sendmsg(). Otherwise, it's just a cleanup.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] RDS: use gfp flags from caller in conn_alloc()
2012-03-22 15:19 ` Venkat Venkatsubra
@ 2012-03-22 23:30 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-03-22 23:30 UTC (permalink / raw)
To: venkat.x.venkatsubra; +Cc: dan.carpenter, rds-devel, netdev, kernel-janitors
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Date: Thu, 22 Mar 2012 10:19:50 -0500
> On 3/22/2012 1:44 AM, Dan Carpenter wrote:
>> We should be using the gfp flags the caller specified here, instead of
>> GFP_KERNEL. I think this might be a bugfix, depending on the value of
>> "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in
>> rds_sendmsg(). Otherwise, it's just a cleanup.
>>
>> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-22 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-22 6:44 [patch] RDS: use gfp flags from caller in conn_alloc() Dan Carpenter
2012-03-22 15:19 ` Venkat Venkatsubra
2012-03-22 23:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).