From: Stephen Warren <swarren@wwwdotorg.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Oliver Neukum <oliver@neukum.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Willy Tarreau <willy@meta-x.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: Regression due to: net/usbnet: avoid recursive locking in usbnet_stop()
Date: Fri, 23 Mar 2012 10:53:02 -0600 [thread overview]
Message-ID: <4F6CAA6E.4070401@wwwdotorg.org> (raw)
In-Reply-To: <CACVXFVMPqXr+AuoBj9R5Fk=_UOPaozm2ok9zd9N-_JUOe8cu4g@mail.gmail.com>
On 03/22/2012 09:28 PM, Ming Lei wrote:
> On Fri, Mar 23, 2012 at 6:56 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> It looks like commit 4231d47e6fe69f061f96c98c30eaf9fb4c14b96d
>> "net/usbnet: avoid recursive locking in usbnet_stop()" causes a problem
>> for me.
>>
>> When I reboot or shutdown, I see the error spew below at least 50% of
>> the time. Reverting the above patch fixes this, at least for 10 reboot
>> attempts.
>
> The two patches[1][2] should fix your problem, please try them.
> Both have been applied into David's tree.
>
> [1], http://marc.info/?l=linux-usb&m=133242262312402&w=2
> [2], http://marc.info/?l=linux-usb&m=133242264412410&w=2
Those two patches do solve the problem I was seeing, thanks.
FWIW, too late, but:
Tested-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2012-03-23 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 22:56 Regression due to: net/usbnet: avoid recursive locking in usbnet_stop() Stephen Warren
2012-03-23 3:28 ` Ming Lei
2012-03-23 16:53 ` Stephen Warren [this message]
2012-03-23 7:21 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6CAA6E.4070401@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).