netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <tarbal@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] e1000: Silence sparse warnings by correcting type
Date: Sun, 25 Mar 2012 02:45:13 -0700	[thread overview]
Message-ID: <4F6EE929.9090100@gmail.com> (raw)
In-Reply-To: <1332233951-31129-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

On 03/20/2012 01:59 AM, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko<andrei.emeltchenko@intel.com>
>
> Silence sparse warnings shown below:
> ...
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> 	cast to restricted __le64
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> 	cast to restricted __le64
> ...
>
> Signed-off-by: Andrei Emeltchenko<andrei.emeltchenko@intel.com>
> ---
>   drivers/net/ethernet/intel/e1000/e1000_main.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 6419a88..1bf73cf 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
>   	for (i = 0; tx_ring->desc&&  (i<  tx_ring->count); i++) {
>   		struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
>   		struct e1000_buffer *buffer_info =&tx_ring->buffer_info[i];
> -		struct my_u { u64 a; u64 b; };
> +		struct my_u { __le64 a; __le64 b; };
>   		struct my_u *u = (struct my_u *)tx_desc;
>   		const char *type;
>
> @@ -3421,7 +3421,7 @@ rx_ring_summary:
>   	for (i = 0; rx_ring->desc&&  (i<  rx_ring->count); i++) {
>   		struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
>   		struct e1000_buffer *buffer_info =&rx_ring->buffer_info[i];
> -		struct my_u { u64 a; u64 b; };
> +		struct my_u { __le64 a; __le64 b; };
>   		struct my_u *u = (struct my_u *)rx_desc;
>   		const char *type;
>
Helps if you CC the maintainers (i.e. me)

Thanks, I will add it to my queue of e1000 patches.

      parent reply	other threads:[~2012-03-25  9:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20  8:59 [PATCH] e1000: Silence sparse warnings by correcting type Andrei Emeltchenko
2012-03-23 14:01 ` Andrei Emeltchenko
2012-03-25  9:45 ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6EE929.9090100@gmail.com \
    --to=tarbal@gmail.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).