From: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
To: david.ward@ll.mit.edu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/vlan: withdraw VLAN ID attribute from GVRP on VLAN device stop
Date: Mon, 26 Mar 2012 13:29:45 +0200 [thread overview]
Message-ID: <4F705329.10208@dti2.net> (raw)
In-Reply-To: <1332715437-16278-2-git-send-email-david.ward@ll.mit.edu>
El 26/03/2012 0:43, David Ward escribió:
> When a VLAN device is stopped which has VLAN_FLAG_GVRP set, the VLAN
> ID attribute that was previously declared by GVRP must be withdrawn.
>
Hmm, maybe I am missing something but I think it only makes sense to withdrawn
the attribute when you delete the interface, and vlan_dev_stop() it's called if
you just put the interface down. It's better for the network convergence to not
signal the switches just for this. IMHO.
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
> ---
> net/8021q/vlan_dev.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index 9988d4a..df86dd0 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -319,6 +319,9 @@ static int vlan_dev_stop(struct net_device *dev)
> struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
> struct net_device *real_dev = vlan->real_dev;
>
> + if (vlan->flags & VLAN_FLAG_GVRP)
> + vlan_gvrp_request_leave(dev);
> +
> dev_mc_unsync(real_dev, dev);
> dev_uc_unsync(real_dev, dev);
> if (dev->flags & IFF_ALLMULTI)
next prev parent reply other threads:[~2012-03-26 11:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 22:43 [PATCH] net/garp: avoid infinite loop if attribute already exists David Ward
2012-03-25 22:43 ` [PATCH] net/vlan: withdraw VLAN ID attribute from GVRP on VLAN device stop David Ward
2012-03-26 11:29 ` Jorge Boncompte [DTI2] [this message]
2012-03-26 13:38 ` Ward, David - 0663 - MITLL
2012-03-26 15:14 ` Jorge Boncompte [DTI2]
2012-03-26 15:50 ` Ward, David - 0663 - MITLL
2012-03-26 21:42 ` David Miller
2012-03-27 1:35 ` Ward, David - 0663 - MITLL
2012-03-26 11:23 ` [PATCH] net/garp: avoid infinite loop if attribute already exists Jorge Boncompte [DTI2]
2012-03-26 14:11 ` Ward, David - 0663 - MITLL
2012-03-26 15:26 ` Jorge Boncompte [DTI2]
2012-03-26 16:07 ` Ward, David - 0663 - MITLL
2012-03-27 19:01 ` [PATCH v2] " David Ward
2012-03-28 11:28 ` Jorge Boncompte [DTI2]
2012-03-28 13:28 ` Ward, David - 0663 - MITLL
2012-03-28 20:45 ` David Miller
2012-03-26 21:44 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F705329.10208@dti2.net \
--to=jorge@dti2.net \
--cc=david.ward@ll.mit.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).