From: Li Yu <raise.sail@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH] tcp: remove useless update for flag parameter in tcp_enter_frto_loss()
Date: Wed, 28 Mar 2012 12:23:17 +0800 [thread overview]
Message-ID: <4F729235.8040706@gmail.com> (raw)
It seem that we forget remove below two lines after copying code :)
This update never impacts others.
Sorry for last mail with legal notices improperly, I used wrong
mail.
Signed-off-by Li Yu <bingtian.ly@taobao.com>
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index e886e2f..b2f8ada 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2169,8 +2169,6 @@ static void tcp_enter_frto_loss(struct sock *sk,
int allowed_segments, int flag)
/* For some reason this R-bit might get cleared? */
if (TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_RETRANS)
tp->retrans_out += tcp_skb_pcount(skb);
- /* ...enter this if branch just for the first segment */
- flag |= FLAG_DATA_ACKED;
} else {
if (TCP_SKB_CB(skb)->sacked & TCPCB_RETRANS)
tp->undo_marker = 0;
next reply other threads:[~2012-03-28 4:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 4:23 Li Yu [this message]
2012-03-28 5:27 ` [PATCH] tcp: remove useless update for flag parameter in tcp_enter_frto_loss() Yuchung Cheng
2012-03-28 5:29 ` Neal Cardwell
2012-03-28 6:54 ` Li Yu
2012-03-28 7:34 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2012-03-28 4:00 Li Yu
2012-03-28 4:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F729235.8040706@gmail.com \
--to=raise.sail@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).