From: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
To: david.ward@ll.mit.edu
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH v2] net/garp: avoid infinite loop if attribute already exists
Date: Wed, 28 Mar 2012 13:28:22 +0200 [thread overview]
Message-ID: <4F72F5D6.5080903@dti2.net> (raw)
In-Reply-To: <1332874912-1979-1-git-send-email-david.ward@ll.mit.edu>
El 27/03/2012 21:01, David Ward escribió:
> An infinite loop occurred if garp_attr_create was called with the values
> of an existing attribute. This might happen if a previous leave request
> for the attribute has not yet been followed by a PDU transmission (or,
> if the application previously issued a join request for the attribute
> and is now issuing another one, without having issued a leave request).
>
> If garp_attr_create finds an existing attribute having the same values,
> return the address to it. Its state will then get updated (i.e., if it
> was in a leaving state, it will move into a non-leaving state and not
> get deleted during the next PDU transmission).
>
> To accomplish this fix, collapse garp_attr_insert into garp_attr_create
> (which is its only caller).
>
I wouldn't mind if you credited me given that your patch now is based on my fix
and analysis. ;-)
Anyway...
Acked-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
next prev parent reply other threads:[~2012-03-28 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 22:43 [PATCH] net/garp: avoid infinite loop if attribute already exists David Ward
2012-03-25 22:43 ` [PATCH] net/vlan: withdraw VLAN ID attribute from GVRP on VLAN device stop David Ward
2012-03-26 11:29 ` Jorge Boncompte [DTI2]
2012-03-26 13:38 ` Ward, David - 0663 - MITLL
2012-03-26 15:14 ` Jorge Boncompte [DTI2]
2012-03-26 15:50 ` Ward, David - 0663 - MITLL
2012-03-26 21:42 ` David Miller
2012-03-27 1:35 ` Ward, David - 0663 - MITLL
2012-03-26 11:23 ` [PATCH] net/garp: avoid infinite loop if attribute already exists Jorge Boncompte [DTI2]
2012-03-26 14:11 ` Ward, David - 0663 - MITLL
2012-03-26 15:26 ` Jorge Boncompte [DTI2]
2012-03-26 16:07 ` Ward, David - 0663 - MITLL
2012-03-27 19:01 ` [PATCH v2] " David Ward
2012-03-28 11:28 ` Jorge Boncompte [DTI2] [this message]
2012-03-28 13:28 ` Ward, David - 0663 - MITLL
2012-03-28 20:45 ` David Miller
2012-03-26 21:44 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F72F5D6.5080903@dti2.net \
--to=jorge@dti2.net \
--cc=david.ward@ll.mit.edu \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).