From: John Fastabend <john.r.fastabend@intel.com>
To: Roopa Prabhu <roprabhu@cisco.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] macvlan: add FDB bridge ops
Date: Thu, 29 Mar 2012 18:06:25 -0700 [thread overview]
Message-ID: <4F750711.2060508@intel.com> (raw)
In-Reply-To: <CB9A2187.4A989%roprabhu@cisco.com>
On 3/29/2012 2:26 PM, Roopa Prabhu wrote:
>
>
>
> On 3/28/12 8:58 AM, "John Fastabend" <john.r.fastabend@intel.com> wrote:
>
>> On 3/28/2012 8:52 AM, Michael S. Tsirkin wrote:
>>> On Wed, Mar 28, 2012 at 08:43:56AM -0700, Roopa Prabhu wrote:
>>>> On 3/20/12 5:26 PM, "John Fastabend" <john.r.fastabend@intel.com> wrote:
>>>>
>>>>> Add support to add/del and dump the forwarding database
>>>>> for macvlan passthru mode. The macvlan driver acts like
>>>>> a Two Port Mac Relay (TPMR 802.1Q-2011) in the passthru
>>>>> case so adding forwarding rules is just adding the addr
>>>>> to the uc or mc lists.
>>>>>
[...]
>>>
>>>
>>> So this clears the promisc on the first add which
>>> is a bit annoying. How about a simple flag, set when
>>> we create the macvlan?
>>>
>>
>> Agreed. This probably needs a new attrib maybe IFLA_MACVLAN_FLAGS unless
>> there already exists a per "kind" (rtnl_link_ops) flags field we can use.
>> I scanned the code briefly and didn't see any such thing so likely we need
>> the new attribute.
>
> O ok. That makes sense. Unfortunately I am not sure if I will be able to get
> back to this anytime in the near future. If anyone wants to rework this
> patch please do.
>
> Thanks.
> Roopa
>
>
OK I'll fix it up and submit it with the rest of the FDB
patches.
.John
prev parent reply other threads:[~2012-03-30 1:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 0:26 [RFC PATCH] macvlan: add FDB bridge ops John Fastabend
2012-03-21 8:34 ` Michael S. Tsirkin
2012-03-28 15:43 ` Roopa Prabhu
2012-03-28 15:52 ` Michael S. Tsirkin
2012-03-28 15:58 ` John Fastabend
2012-03-29 21:26 ` Roopa Prabhu
2012-03-30 1:06 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F750711.2060508@intel.com \
--to=john.r.fastabend@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).