From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: rayagond@vayavyalabs.com, netdev@vger.kernel.org
Subject: Re: [PATCH] stmmac: re-add IFF_UNICAST_FLT for dwmac1000
Date: Wed, 04 Apr 2012 09:33:21 +0200 [thread overview]
Message-ID: <4F7BF941.1020009@pengutronix.de> (raw)
In-Reply-To: <4F7BF165.6060106@st.com>
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
On 04/04/2012 08:59 AM, Giuseppe CAVALLARO wrote:
> On 4/3/2012 7:44 PM, Marc Kleine-Budde wrote:
>> In commit (bfab27a stmmac: add the experimental PCI support) the
^^^^^^^
>
> I get another patch associated to this commit:
>
> git show db8857b
^^^^^^^
Copy paste problem on your side?
> commit db8857bf5bd888d763e1984f9449d0b824b39ee1
> Author: Florian Fainelli <florian@openwrt.org>
> Date: Mon Jan 9 23:59:20 2012 +0000
>
> stmmac: use an unique MDIO bus name.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
>
> maybe, the commit should be:
>
> git-show bfab27a14
^^^^^^^^^
Yes, as I've written in my commit message.
> commit bfab27a146ed4d722c6d399f844f955f29cd2b81
> Author: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Wed Dec 21 03:58:19 2011 +0000
>
> stmmac: add the experimental PCI support
>
>
>> IFF_UNICAST_FLT flag has been removed from the stmmac_mac_device_setup()
>> function. This patch re-adds the flag.
>
> Yes this flag was removed by this PCI patch.
> So it makes sense to re-add it!
>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Tnx.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2012-04-04 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:44 [PATCH] stmmac: re-add IFF_UNICAST_FLT for dwmac1000 Marc Kleine-Budde
2012-04-03 18:20 ` Eric Dumazet
2012-04-04 7:33 ` Marc Kleine-Budde
2012-04-04 6:59 ` Giuseppe CAVALLARO
2012-04-04 7:33 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7BF941.1020009@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).