From: Michal Simek <monstr@monstr.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
John Williams <john.williams@petalogix.com>,
David Miller <davem@davemloft.net>
Subject: net: more accurate skb truesize - regression on Microblaze
Date: Tue, 10 Apr 2012 10:10:54 +0200 [thread overview]
Message-ID: <4F83EB0E.4020104@monstr.eu> (raw)
Hi Eric,
I have spent some time to investigate what it is causing regression on our network bechmark
and I have identified that your patch "net: more accurate skb truesize" is causing that.
I see regression especially on incoming tcp (RX) connection which is 20%. On TX I see regression till 5%.
In general microblaze systems are pretty sensitive for memory usage and working with it.
Increasing packet sizes has big impact on performance.
I was surprised that regression is so high.
From microblaze point of view is more important to remove that performance regression
than having more accurate memory accounting. 20% performance regression is simple so high
for that.
Isn't there any other way to doing better memory accounting?
Or is there any workaround which would be possible to use?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next reply other threads:[~2012-04-10 8:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 8:10 Michal Simek [this message]
2012-04-10 8:27 ` net: more accurate skb truesize - regression on Microblaze Eric Dumazet
2012-04-10 8:32 ` Eric Dumazet
2012-04-10 8:37 ` Michal Simek
2012-04-10 8:45 ` Eric Dumazet
2012-04-10 9:11 ` Michal Simek
2012-04-10 9:24 ` Eric Dumazet
2012-04-10 9:29 ` Michal Simek
2012-04-10 9:38 ` Eric Dumazet
2012-04-10 9:50 ` Michal Simek
2012-04-10 9:52 ` Eric Dumazet
2012-04-10 10:03 ` Michal Simek
2012-04-10 10:03 ` [PATCH] tcp: restore correct limit Eric Dumazet
2012-04-10 10:14 ` Michal Simek
2012-04-10 10:29 ` Jason Wang
2012-04-10 10:32 ` Michal Simek
2012-04-10 10:40 ` Eric Dumazet
2012-04-10 10:56 ` [PATCH v2] " Eric Dumazet
2012-04-10 18:42 ` David Miller
2012-04-10 11:32 ` net: more accurate skb truesize - regression on Microblaze Eric Dumazet
2012-04-10 11:38 ` Michal Simek
2012-04-10 11:50 ` Eric Dumazet
2012-04-10 12:12 ` Michal Simek
2012-04-10 13:43 ` David Miller
[not found] ` <CAHTX3dLRR09_QaA2BzmbCVAUVVGvr_P3s2d1KEgPLMYGGVzrpA@mail.gmail.com>
2012-04-10 13:52 ` David Miller
[not found] ` <CAHTX3dLz9+A48u6ckGiDytBkyMrvgV0Zi3xfnt4RBmoagJbndA@mail.gmail.com>
2012-04-10 14:14 ` David Miller
2012-04-10 14:38 ` Michal Simek
2012-04-10 8:36 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F83EB0E.4020104@monstr.eu \
--to=monstr@monstr.eu \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.williams@petalogix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).