From: Stephen Boyd <sboyd@codeaurora.org>
To: Matt Renzelmann <mjr@cs.wisc.edu>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH] ks8851: Cancel any pending IRQ work
Date: Fri, 13 Apr 2012 11:32:21 -0700 [thread overview]
Message-ID: <4F887135.5080005@codeaurora.org> (raw)
In-Reply-To: <005701cd18eb$aaa0ab90$ffe202b0$@cs.wisc.edu>
On 04/12/12 13:34, Matt Renzelmann wrote:
> I agree on all counts -- the patch is buggy, though it does at least "shrink"
> the window of vulnerability. Frankly, I don't believe I'm qualified to write an
> appropriate patch for this driver, at least without spending considerably more
> time on it.
>
> FWIW, I found this problem with a new driver-testing tool we've developed called
> SymDrive, and my goal is primarily to determine if the bug is real or not. The
> tool is imperfect and we are trying to validate its operation.
The bug is real if your interrupt controller is broken :-) One could
argue that it's outside the scope of this driver to handle broken
interrupt controllers or buggy genirq code, but being defensive sounds
like a good idea.
>
> That said, if there is an issue here, and we can come up with an appropriate
> fix, then I'd be happy to write a patch for it.
>
I'll see what I can do in the next few days about the deadlock I mentioned.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2012-04-13 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 16:44 [PATCH] ks8851: Cancel any pending IRQ work mjr
2012-04-12 20:19 ` Stephen Boyd
2012-04-12 20:34 ` Matt Renzelmann
2012-04-13 18:32 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F887135.5080005@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=ben-linux@fluff.org \
--cc=davem@davemloft.net \
--cc=mjr@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).