From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, rayagond@vayavyalabs.com, davem@davemloft.net
Subject: Re: [net-next 1/4 (V3)] net: ethtool: add the EEE support
Date: Mon, 16 Apr 2012 07:41:23 +0200 [thread overview]
Message-ID: <4F8BB103.7020107@st.com> (raw)
In-Reply-To: <1334269598.2497.50.camel@bwh-desktop.uk.solarflarecom.com>
On 4/13/2012 12:26 AM, Ben Hutchings wrote:
> On Fri, 2012-04-06 at 11:29 +0200, Giuseppe CAVALLARO wrote:
>> This patch adds two new functions to detect if Energy-Efficient
>> Ethernet (EEE) is supported and the way to enable/disable it.
>>
>> As Ben said, it is certainly necessary to distinguish:
>>
>> a. PHY is advertising EEE from
>> b. Link partner is advertising EEE
>> or
>> c. EEE will be used (= a && b)
>>
>> The logic behind this code, is that .get_eee will pass
>> to the user-space if the EEE is actually used and available (so point c).
>> The .set_eee should used to force the MAC to disable/enable the EEE (if
>> actually supported by MAC+PHY).
> [...]
>
> What I meant is that userland should be able to find out (a), and,
> *separately*, either (b) or (c). That is, there must be at least 2
> separate flags for this. In fact, I explicitly requested you define
> supported/advertising/lp_advertising bitmasks for EEE link modes just
> like we have for autonegotiation. But you've made no substantive
> changes in response to my review, aside from dropping the added field in
> ethtool_cmd.
Sorry Ben but I believed that (c) was enough.
> What you're submitting just isn't good enough for a generic interface,
> as the ethtool API is supposed to be. It's not even a good interface to
> your driver.
yes! I'll rework this and provide new patches asap.
peppe
> Ben.
>
next prev parent reply other threads:[~2012-04-16 5:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 9:29 [net-next 0/4 (V3)] stmmac & EEE support Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 1/4 (V3)] net: ethtool: add the " Giuseppe CAVALLARO
2012-04-12 22:26 ` Ben Hutchings
2012-04-16 5:41 ` Giuseppe CAVALLARO [this message]
2012-04-19 12:58 ` Giuseppe CAVALLARO
2012-04-19 13:48 ` Yuval Mintz
2012-04-19 15:14 ` Ben Hutchings
2012-04-19 15:30 ` Ben Hutchings
2012-04-26 7:48 ` Giuseppe CAVALLARO
2012-04-26 17:17 ` Ben Hutchings
2012-04-27 14:11 ` Giuseppe CAVALLARO
2012-04-29 9:20 ` Yuval Mintz
2012-04-29 21:56 ` Ben Hutchings
2012-05-07 5:25 ` Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 2/4 (V3)] phy: add the EEE support and the way to access to the MMD regs Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 3/4 (V3)] stmmac: add the Energy Efficient Ethernet support Giuseppe CAVALLARO
2012-04-12 20:32 ` David Miller
2012-04-13 6:35 ` Giuseppe CAVALLARO
2012-04-06 9:29 ` [net-next 4/4 (V3)] stmmac: update the driver Documentation and add EEE Giuseppe CAVALLARO
2012-04-06 9:29 ` [PATCH] ethtool: add the EEE option Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8BB103.7020107@st.com \
--to=peppe.cavallaro@st.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rayagond@vayavyalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).