* [PATCH] net: fix compile error of leaking kmemleak.h header
@ 2012-04-19 4:05 Shan Wei
2012-04-19 4:08 ` Shan Wei
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Shan Wei @ 2012-04-19 4:05 UTC (permalink / raw)
To: David Miller; +Cc: majianpeng, Eric Dumazet, NetDev, davidshan
From: Shan Wei <davidshan@tencent.com>
net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
with same error in net/ipv4/route.c
Signed-off-by: Shan Wei <davidshan@tencent.com>
---
net/core/sysctl_net_core.c | 1 +
net/ipv4/route.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
index cee5991..247c69b 100644
--- a/net/core/sysctl_net_core.c
+++ b/net/core/sysctl_net_core.c
@@ -14,6 +14,7 @@
#include <linux/vmalloc.h>
#include <linux/init.h>
#include <linux/slab.h>
+#include <linux/kmemleak.h>
#include <net/ip.h>
#include <net/sock.h>
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index bcd4744..a1c115d 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -109,6 +109,7 @@
#include <net/rtnetlink.h>
#ifdef CONFIG_SYSCTL
#include <linux/sysctl.h>
+#include <linux/kmemleak.h>
#endif
#include <net/secure_seq.h>
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: fix compile error of leaking kmemleak.h header
2012-04-19 4:05 [PATCH] net: fix compile error of leaking kmemleak.h header Shan Wei
@ 2012-04-19 4:08 ` Shan Wei
2012-04-19 4:13 ` David Miller
2012-04-19 4:22 ` Eric Dumazet
2 siblings, 0 replies; 4+ messages in thread
From: Shan Wei @ 2012-04-19 4:08 UTC (permalink / raw)
To: David Miller; +Cc: majianpeng, Eric Dumazet, NetDev, davidshan
Shan Wei said, at 2012/4/19 12:05:
> From: Shan Wei <davidshan@tencent.com>
>
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
>
> with same error in net/ipv4/route.c
This is for net-next.....
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: fix compile error of leaking kmemleak.h header
2012-04-19 4:05 [PATCH] net: fix compile error of leaking kmemleak.h header Shan Wei
2012-04-19 4:08 ` Shan Wei
@ 2012-04-19 4:13 ` David Miller
2012-04-19 4:22 ` Eric Dumazet
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-04-19 4:13 UTC (permalink / raw)
To: shanwei88; +Cc: majianpeng, eric.dumazet, netdev, davidshan
From: Shan Wei <shanwei88@gmail.com>
Date: Thu, 19 Apr 2012 12:05:46 +0800
> From: Shan Wei <davidshan@tencent.com>
>
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
>
> with same error in net/ipv4/route.c
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: fix compile error of leaking kmemleak.h header
2012-04-19 4:05 [PATCH] net: fix compile error of leaking kmemleak.h header Shan Wei
2012-04-19 4:08 ` Shan Wei
2012-04-19 4:13 ` David Miller
@ 2012-04-19 4:22 ` Eric Dumazet
2 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2012-04-19 4:22 UTC (permalink / raw)
To: Shan Wei; +Cc: David Miller, majianpeng, NetDev, davidshan
On Thu, 2012-04-19 at 12:05 +0800, Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
>
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
>
> with same error in net/ipv4/route.c
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> ---
> net/core/sysctl_net_core.c | 1 +
> net/ipv4/route.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index cee5991..247c69b 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -14,6 +14,7 @@
> #include <linux/vmalloc.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> +#include <linux/kmemleak.h>
>
> #include <net/ip.h>
> #include <net/sock.h>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index bcd4744..a1c115d 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -109,6 +109,7 @@
> #include <net/rtnetlink.h>
> #ifdef CONFIG_SYSCTL
> #include <linux/sysctl.h>
> +#include <linux/kmemleak.h>
> #endif
> #include <net/secure_seq.h>
>
yep, SLAB doesnt include it like SLUB
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-19 4:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-19 4:05 [PATCH] net: fix compile error of leaking kmemleak.h header Shan Wei
2012-04-19 4:08 ` Shan Wei
2012-04-19 4:13 ` David Miller
2012-04-19 4:22 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).