From: Viresh Kumar <viresh.kumar@st.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
spear-devel <spear-devel@list.st.com>
Subject: Re: [net-next 3/4] stmmac: verify the dma_cfg platform fields
Date: Thu, 19 Apr 2012 11:35:06 +0530 [thread overview]
Message-ID: <4F8FAB12.2060108@st.com> (raw)
In-Reply-To: <1334814502-29707-3-git-send-email-peppe.cavallaro@st.com>
On 4/19/2012 11:18 AM, Giuseppe CAVALLARO wrote:
> Recently the dma parameters that can be passed from the platform
> have been moved from the plat_stmmacenet_data to the stmmac_dma_cfg.
>
> In case of this new structure is not well allocated the driver can
> fails. This is an example how this field is managed in ST platforms
>
> static struct stmmac_dma_cfg gmac_dma_setting = {
> .pbl = 32,
> };
>
> static struct plat_stmmacenet_data stih415_ethernet_platform_data[] = {
> {
> .dma_cfg = &gmac_dma_setting,
> .has_gmac = 1,
> [snip]
>
> This patch so verifies that the dma_cfg passed from the platform.
> In case of it is NULL there is no reason that the driver has to fail
> and some default values can be passed. These are ok for all the
> Synopsys chips and could impact on performances, only.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> cc: Viresh Kumar <viresh.kumar@st.com>
I really can't review it, as i am not stmmac expert. But, i am sure
the problem i highlighted will be resolved by this patch.
Another thing, as SPEAr is using stmmac, can you always cc spear-devel@list.st.com
for all stmmac patches.
--
viresh
next prev parent reply other threads:[~2012-04-19 6:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 5:48 [net-next 1/4] stmmac: use custom init/exit functions in pm ops Giuseppe CAVALLARO
2012-04-19 5:48 ` [net-next 2/4 (v2)] stmmac: Move the mdio_register/_unregister in probe/remove Giuseppe CAVALLARO
2012-04-20 0:09 ` David Miller
2012-04-19 5:48 ` [net-next 3/4] stmmac: verify the dma_cfg platform fields Giuseppe CAVALLARO
2012-04-19 6:05 ` Viresh Kumar [this message]
2012-04-19 6:29 ` Giuseppe CAVALLARO
2012-04-20 0:09 ` David Miller
2012-04-19 5:48 ` [net-next 4/4] stmmac: do not fail when probe and there is no csr clk defined Giuseppe CAVALLARO
2012-04-20 0:09 ` David Miller
2012-04-20 0:06 ` [net-next 1/4] stmmac: use custom init/exit functions in pm ops David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FAB12.2060108@st.com \
--to=viresh.kumar@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).