From: "Peter Huang(Peng)" <peter.huangpeng@huawei.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "'David S. Miller'" <davem@davemloft.net>,
netdev@vger.kernel.org, ctrix+debianbugs@navynet.it,
Eric Dumazet <eric.dumazet@gmail.com>,
harry.majun@huawei.com, linux-kernel@vger.kernel.org,
peter.huangpeng@gmail.com
Subject: Re: [PATCH v3] set fake_rtable's dst to NULL to avoid kernel Oops.
Date: Thu, 19 Apr 2012 16:58:47 +0800 [thread overview]
Message-ID: <4F8FD3C7.2030006@huawei.com> (raw)
In-Reply-To: <20120418234649.0bcb3872@nehalam.linuxnetplumber.net>
On 2012/4/19 14:46, Stephen Hemminger wrote:
> On Thu, 19 Apr 2012 10:27:01 +0800
> "Peter Huang(Peng)"<peter.huangpeng@huawei.com> wrote:
>
>> When bridge is deleted before tap/vif device's delete, kernel may
>> encounter an oops because of NULL reference to fake_rtable's dst.
>> Set fake_rtable's dst to NULL before sending packets out can solve this
>> problem.
>>
>> v3 enrich commit header
>>
>> v2 added a new flag DST_FAKE_RTABLE to dst_entry struct.
>>
>>
>> Acked-by: Eric Dumazet<eric.dumazet@gmail.com>
>> Signed-off-by: Peter Huang<peter.huangpeng@huawei.com>
>
> I am okay with the contents of the patch but the formatting is all
> botched. It adds bad indentation and whitespace, please run it
> through checkpatch.
Got it, I will send the v4 version of modified format.
Thanks!
prev parent reply other threads:[~2012-04-19 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 2:27 [PATCH v3] set fake_rtable's dst to NULL to avoid kernel Oops Peter Huang(Peng)
2012-04-19 6:46 ` Stephen Hemminger
2012-04-19 8:58 ` Peter Huang(Peng) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FD3C7.2030006@huawei.com \
--to=peter.huangpeng@huawei.com \
--cc=ctrix+debianbugs@navynet.it \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=harry.majun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.huangpeng@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).