From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events Date: Thu, 19 Apr 2012 15:36:57 +0400 Message-ID: <4F8FF8D9.5080503@parallels.com> References: <20120419105707.32131.79719.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Pavel Emelianov , "neilb-l3A5Bk7waGM@public.gmane.org" , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , James Bottomley , "bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org" , "davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org" , "devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org" To: "Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org" Return-path: In-Reply-To: <20120419105707.32131.79719.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Sorry, but ignore this patch too. It can't be that simple because of these cl_count tricks in rpc_release= _client... 19.04.2012 14:57, Stanislav Kinsbursky =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > These clients can't be safely dereferenced if their counter in 0. > > Signee-off-by: Stanislav Kinsbursky > > Signed-off-by: Stanislav Kinsbursky > > --- > net/sunrpc/clnt.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index 6797246..591994d 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -218,7 +218,8 @@ static struct rpc_clnt *rpc_get_client_for_event(= struct net *net, int event) > if (((event =3D=3D RPC_PIPEFS_MOUNT)&& clnt->cl_dentry) || > ((event =3D=3D RPC_PIPEFS_UMOUNT)&& !clnt->cl_dentry)) > continue; > - atomic_inc(&clnt->cl_count); > + if (atomic_inc_return(&clnt->cl_count) =3D=3D 1) > + continue; > spin_unlock(&sn->rpc_client_lock); > return clnt; > } > --=20 Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html