From: "Ward, David - 0663 - MITLL" <david.ward@ll.mit.edu>
To: Thomas Graf <tgraf@suug.ch>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: net_sched: gred: red_calc_qavg() called with current qavg for backlog?
Date: Sat, 21 Apr 2012 14:46:31 -0400 [thread overview]
Message-ID: <4F930087.7010004@ll.mit.edu> (raw)
In net/sched/sch_gred.c:
static int gred_dump(struct Qdisc *sch, struct sk_buff *skb)
{
struct gred_sched *table = qdisc_priv(sch);
...
for (i = 0; i < MAX_DPs; i++) {
struct gred_sched_data *q = table->tab[i];
struct tc_gred_qopt opt;
...
opt.qave = red_calc_qavg(&q->parms, &q->vars, q->vars.qavg);
I can't tell if red_calc_qavg is intentionally being passed the current
qavg as the backlog (which effectively causes qavg to only be
re-calculated if we are idling)? Or should this be:
opt.qave = red_calc_qavg(&q->parms,
&q->vars,
gred_backlog(table, q, sch));
Thanks,
David
next reply other threads:[~2012-04-21 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 18:46 Ward, David - 0663 - MITLL [this message]
2012-04-21 20:10 ` net_sched: gred: red_calc_qavg() called with current qavg for backlog? David Miller
2012-04-24 12:37 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F930087.7010004@ll.mit.edu \
--to=david.ward@ll.mit.edu \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).