From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH net-next 05/19] net: Move all of the network sysctls without a namespace into init_net. Date: Mon, 23 Apr 2012 08:38:44 +0800 Message-ID: <4F94A494.7020006@cn.fujitsu.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , netdev@vger.kernel.org, "Serge E. Hallyn" , pablo@netfilter.org, Stephen Hemminger , Pavel Emelyanov To: "Eric W. Biederman" Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:17048 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753058Ab2DWAiR convert rfc822-to-8bit (ORCPT ); Sun, 22 Apr 2012 20:38:17 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: =E4=BA=8E 2012=E5=B9=B404=E6=9C=8820=E6=97=A5 07:24, Eric W. Biederman = =E5=86=99=E9=81=93: >=20 > This makes it clearer which sysctls are relative to your current netw= ork > namespace. >=20 > This makes it a little less error prone by not exposing sysctls for t= he > initial network namespace in other namespaces. >=20 > This is the same way we handle all of our other network interfaces to > userspace and I can't honestly remember why we didn't do this for > sysctls right from the start. >=20 > Signed-off-by: Eric W. Biederman > --- > drivers/infiniband/core/ucma.c | 4 ++-- > net/802/tr.c | 2 +- > net/appletalk/sysctl_net_atalk.c | 4 ++-- > net/ax25/sysctl_net_ax25.c | 4 ++-- > net/bridge/br_netfilter.c | 4 ++-- > net/core/neighbour.c | 2 +- > net/core/sysctl_net_core.c | 2 +- > net/dccp/sysctl.c | 4 ++-- > net/decnet/dn_dev.c | 4 ++-- > net/decnet/sysctl_net_decnet.c | 4 ++-- > net/ipv4/netfilter/ip_queue.c | 6 +++--- > net/ipv4/route.c | 2 +- > net/ipv4/sysctl_net_ipv4.c | 4 ++-- > net/ipv6/netfilter/ip6_queue.c | 6 +++--- > net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++-- > net/ipv6/sysctl_net_ipv6.c | 2 +- > net/ipx/sysctl_net_ipx.c | 5 +++-- > net/irda/irsysctl.c | 4 ++-- > net/llc/sysctl_net_llc.c | 5 +++-- > net/netfilter/nf_conntrack_proto.c | 4 ++-- Hi Eric actually,I'm working on making the sysctl and data of nf_conntrack prot= o pernet, and I think it's necessary,without the pernet proto timeout,we can't co= ntrol the container's conntrack timeout unless we change the host's timeout. maybe somebody want the conntracks in container expired quickly. So I will keep on doing this job base on your patchset. what's your comment? Thanks, Gao